Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Java udemy course #4580

Closed
wants to merge 2 commits into from
Closed

updated Java udemy course #4580

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
868a507
updated Java udemy course
Oct 21, 2020
ef19285
Suggested Changes
Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion free-courses-en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@
* [Princeton Algorithms, Part 1](https://www.coursera.org/course/algs4partI)
* [Problem Solving With Java](https://www.udacity.com/course/intro-to-java-programming--cs046) (Udacity)
* [Spring 5 Core - An Ultimate Guide](https://www.udemy.com/learn-spring-5-core-from-scratch/) - Somnath Musib (Udemy)

* [Java Design Patterns and Architecture](https://www.udemy.com/course/java-design-patterns-tutorial/)- John Purcell (Udemy)

### JavaScript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, the Travis CI build fails for 3 reasons:

  1. It is not in the correct position (needs to be alphabetical) So in this case "Java Design ..." should come first!
  2. There needs to be a space between the https link and the "-". I show this in the suggested code below.
  3. Lastly, the end of this section has 1 blank line before JavaScript, but there should only be 2!

Refer to CONTRIBUTING for the above reasons.

Fixing these will make the Travis CI build work.

Suggested change
* [Java Design Patterns and Architecture](https://www.udemy.com/course/java-design-patterns-tutorial/)- John Purcell (Udemy)
### JavaScript
* [Java Design Patterns and Architecture](https://www.udemy.com/course/java-design-patterns-tutorial/) - John Purcell (Udemy)
### JavaScript

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed !! but PR is failing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, it is due to #4606 mainly


Expand Down