Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Java udemy course #4580

Closed
wants to merge 2 commits into from
Closed

Conversation

anshutoppo
Copy link

@anshutoppo anshutoppo commented Oct 21, 2020

Hacktoberfest notes:

  • due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
  • please read our contributing guidelines
  • be sure to check the output of Travis-CI for linter errors
  • if this is your first open source contribution, make sure it's not your last!

What does this PR do?

Add Resource(s) | Remove Resource(s) | Add info | Improve Repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Not a duplicate
  • Included author(s) if appropriate
  • Lists are in alphabetical order
  • Needed indications added (PDF, access notes, under construction)

@eshellman eshellman closed this Oct 22, 2020
@eshellman eshellman reopened this Oct 22, 2020
Comment on lines 295 to 297
* [Java Design Patterns and Architecture](https://www.udemy.com/course/java-design-patterns-tutorial/)- John Purcell (Udemy)

### JavaScript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, the Travis CI build fails for 3 reasons:

  1. It is not in the correct position (needs to be alphabetical) So in this case "Java Design ..." should come first!
  2. There needs to be a space between the https link and the "-". I show this in the suggested code below.
  3. Lastly, the end of this section has 1 blank line before JavaScript, but there should only be 2!

Refer to CONTRIBUTING for the above reasons.

Fixing these will make the Travis CI build work.

Suggested change
* [Java Design Patterns and Architecture](https://www.udemy.com/course/java-design-patterns-tutorial/)- John Purcell (Udemy)
### JavaScript
* [Java Design Patterns and Architecture](https://www.udemy.com/course/java-design-patterns-tutorial/) - John Purcell (Udemy)
### JavaScript

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed !! but PR is failing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, it is due to #4606 mainly

placed Java Design Alphabetically
fixed spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants