Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Typo #307

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Fixing Typo #307

merged 7 commits into from
Jan 18, 2024

Conversation

gulcing
Copy link

@gulcing gulcing commented Dec 28, 2023

Pull Request checklist

We appreciate your time and effort to improve the tutorial. Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution.


Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes { #293 #294 #295 #300 #302 #303 #304 #305 #306 }

@gulcing gulcing added feature Suggest a feature enhancement New feature or request lesson needs update This is related to changes in esmvaltool/esmvalcore labels Dec 28, 2023
Copy link
Contributor

@LisaBock LisaBock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gulcing ! Great that you revise the text in this way.

Besides one comment I am fine with all changes!

Comment on lines 352 to 353
of length one. We can adapt this function to add our own analysis. As an
example, here we calculate the bias using the average of the data using Iris cubes.
of length one. We can adapt this function to add our own analysis. For example,
here we calculate the bias using the average of the data using Iris cubes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I would keep "As an example, ...". I think the meaning is a bit different. All other changes are fine!

@LisaBock LisaBock self-requested a review January 18, 2024 11:14
Copy link
Contributor

@LisaBock LisaBock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @gulcing !

All fine now! Ready to merge!

@LisaBock LisaBock merged commit fd98947 into main Jan 18, 2024
1 check passed
@LisaBock LisaBock deleted the fixing_typo branch January 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature Suggest a feature lesson needs update This is related to changes in esmvaltool/esmvalcore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants