Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Lesson 9 Writing your own diagnostics script #300

Closed
gulcing opened this issue Dec 12, 2023 · 0 comments
Closed

Typo in Lesson 9 Writing your own diagnostics script #300

gulcing opened this issue Dec 12, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gulcing
Copy link

gulcing commented Dec 12, 2023

In Lesson 9 Writing your own diagnostics script part of " Diagnostic computation“, it is written:

Here we have grouped the input data by variables so we loop over the variables (line 88). Following this, is a call to the function compute_diagnostic (line 93). Let’s have a look at the definition of this function in line 42 where the actual analysis on the data is done.

After grouping and selecting data, we can read individual attributes (such as filename)

I suggest changing to "Here, we have grouped the input data by variables, so we loop over the variables (line 88). Following this is a call to the function compute_diagnostic (line 93). Let’s look at the definition of this function in line 42, where the actual analysis of the data is done."

@gulcing gulcing added the enhancement New feature or request label Dec 12, 2023
@gulcing gulcing self-assigned this Dec 12, 2023
gulcing pushed a commit that referenced this issue Dec 12, 2023
@gulcing gulcing mentioned this issue Dec 28, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants