Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress psy-reg plugin for now (before psy-reg==1.5.0 is released) #3687

Closed
wants to merge 3 commits into from

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jun 26, 2024

Description

psyplot=1.5.0 and psy-reg=1.4.0 are incompatible:

(esmvaltool) valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ conda list psy
# packages in environment at /home/valeriu/miniconda3/envs/esmvaltool:
#
# Name                    Version                   Build  Channel
psy-maps                  1.5.0           py311h38be061_1    conda-forge
psy-reg                   1.4.0           py311h38be061_3    conda-forge
psy-simple                1.5.0           py311h38be061_1    conda-forge
psyplot                   1.5.0           py311h38be061_1    conda-forge
(esmvaltool) valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ python esmvaltool/diag_scripts/psyplot_diag.py
WARNING:psyplot.config.rcsetup:Failed to import EntryPoint(name='plugin', value='psy_reg.plugin', group='psyplot')!
WARNING:psyplot:Could not import EntryPoint(name='plugin', value='psy_reg.plugin', group='psyplot')
Traceback (most recent call last):
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/psyplot/__init__.py", line 132, in get_versions
    mod = ep.load()
          ^^^^^^^^^
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/importlib_metadata/__init__.py", line 184, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/psy_reg/plugin.py", line 36, in <module>
    from psyplot.compat.pycompat import map, filter
ModuleNotFoundError: No module named 'psyplot.compat'
usage: psyplot_diag.py [-h] [-f] [-i] [-n] [-l {debug,info,warning,error}] filename
psyplot_diag.py: error: the following arguments are required: filename

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@valeriupredoi valeriupredoi added this to the v2.11.0 milestone Jun 26, 2024
@valeriupredoi valeriupredoi changed the title suppress psy-reg plugin for now (before psy-reg==1.5.0 is reeased) suppress psy-reg plugin for now (before psy-reg==1.5.0 is released) Jul 3, 2024
@valeriupredoi valeriupredoi modified the milestones: v2.11.0, v2.12.0 Jul 3, 2024
@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Jul 9, 2024

@bouweandela @schlunma do we want to plop this in? Docs builds go through, even if this is flagged as a warning, but the actual diag doesn't work; having said that, psy-reg 1.5.0 will be up soon, so that'll fix this without us doing anything - I am inclined to close this PR, unless yous say something else

@schlunma
Copy link
Contributor

schlunma commented Jul 9, 2024

If the diagnostic doesn't work, I agree that closing this is the best option 👍

@valeriupredoi
Copy link
Contributor Author

Well, it works with this kluge, but not without it, and not before psy-reg 1.5.0

@schlunma
Copy link
Contributor

But we won't need this with psy-reg 1.5.0 which will be out soon? If that's the case, I vote for closing this

@valeriupredoi
Copy link
Contributor Author

indeed, we have thumbs up from Philipp on psy-reg, see #3501 (comment)

@valeriupredoi valeriupredoi deleted the suppress_psy-reg_plugin branch July 10, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation build is failing
2 participants