Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python=3.12 #3501

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Add support for Python=3.12 #3501

wants to merge 54 commits into from

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 18, 2024

Once ESMValGroup/ESMValCore#2228 *allowing support for Python=3.12 in ESMValCore), we should see what roadblocks we have here, so am starting early. That Core PR is currently roadblocked only by prospector not being Python=3.12-compatible, but we're working on that.

Current issues

Previous issues

Also closes #3642

@valeriupredoi
Copy link
Contributor Author

@ESMValGroup/technical-lead-development-team we are inching closer to suppoert Python=3.12 - have a look here https://github.com/ESMValGroup/ESMValTool/actions/runs/8453069262/job/23154935341?pr=3501 - only 4 dependencies need to be rebuilt fro 3.12 - I am a bit at a deadend with prospector though, been waiting on my PR to be merged there since last November; the psy- pkgs I believe that will be updated soon, will go pinch Philipp there; the 🐘 in the room is NCL - am gonna go see what's the atmosphere there; and the pesky one is r-akima - we need to unpin it! 🍺

@valeriupredoi
Copy link
Contributor Author

OK the issue with NCL is not as bad as I thought - it's compatibility with later proj's see NCAR/ncl#210

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Apr 8, 2024

note to self: rerun tests sooner than later, psy-maps only made it to conda-forge just about an hour ago

done 🥳

@valeriupredoi valeriupredoi marked this pull request as ready for review July 9, 2024 12:22
@valeriupredoi
Copy link
Contributor Author

@bouweandela since you are the number one fan of my sort of work these days, here's some good news - we managed to have this show running fine with Py312 - two issues still remain: psy-reg needs to get to 1.5.0 (and py312-sompatible) and prospector, as always 🍺

@Chilipp
Copy link

Chilipp commented Jul 10, 2024

psy-reg needs to get to 1.5.0 (and py312-sompatible)

one urgent issue remains on my todo-list @valeriupredoi, but chances are good that I can work on this within this week 🙈

@valeriupredoi
Copy link
Contributor Author

@Chilipp that's wonderful news, many thanks, mate 🍺 Do let me know if I can help 👍

@bouweandela
Copy link
Member

I checked with the Codacy folks about ruff support, but it's not a very high priority for them, unfortunately.

@valeriupredoi
Copy link
Contributor Author

@bouweandela I got a rather positive reply from @mrfyda at Codacy, check it out codacy/codacy-engine-scala-seed#59 (comment)

@valeriupredoi
Copy link
Contributor Author

in the meantime, I'd argue we remove prospector from our build deps - my view is that Python 3.12 support is probably more important than having prospector in the deps list 😁

@valeriupredoi
Copy link
Contributor Author

@Chilipp is an absolute legend, and now we have the full Psy suite Python 3.12-able, psy-reg too https://anaconda.org/conda-forge/psy-reg - this, my dear Pythoneers, concludes the work on this PR! (nothing we can do about prospector BTW) 🍺

@valeriupredoi valeriupredoi removed the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings during full development installation
3 participants