-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipe recipe_esacci_oc.yml
replace with new regrid scheme nearest_extrapolate
#2841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Unfortunately I cannot really run the recipe at the moment as I am currently travelling and for some reason the Wifi here does not allow a stable connection to Levante longer than a couple of seconds 😢
Would you maybe be able to run the recipe yourself? I am happy to accept if you tell me the recipe runs successfully 😄
@esmvalbot Please run recipe_esacci_oc.yml |
Since @bouweandela asked, ESMValBot will run recipe recipe_esacci_oc.yml as soon as possible, output will be generated here |
@valeriupredoi It would be good to ask the maintainers of the recipe for a review too, so I requested it for you. |
ESMValBot is happy to report recipe recipe_esacci_oc.yml ran OK, output has been generated here |
thanks a lot @schlunma @bouweandela @esmvalbot 😁 I thought that since I've run it no probs myself, and the change is actually needed in light of Core 2.7 I'd not ask for a review from the recipe maintainers, but in hindsight prob better to do it, Lord Loki forbid there's an actual issue with the regridder though 😁 |
@ulrikaw-cloud it would be great if we could get a nod of approval from you on this one asap - it needs to go in the 2.7.0 release because it's replacing a fully deprecated regridding scheme name; the name only changed, so there shouldn't be any functional impact, so if I don't hear from you until Friday, I will merge it 🍺 |
@schlunma @zklaus @bouweandela could I please get an approval on this - this is needed for the release otherwise the recipe is broken, the recipe runs fine, and it has been tested both by me and the bot, the recipe maintainer is not responding, unfortunately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
brill, cheers muchly @schlunma 🍺 |
Description
Before you get started
Older names deprecated, deprecation warning gets deprecated and removed in ESMValGroup/ESMValCore#1753
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic