Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning for regrid schemes already deprecated for v2.7.0 #1753

Merged
merged 7 commits into from
Oct 11, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 10, 2022

Description

Blast! Nearly forgot about these guys 🚳


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1753 (12d492f) into main (bbfa305) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
- Coverage   91.17%   91.16%   -0.01%     
==========================================
  Files         202      202              
  Lines       10890    10882       -8     
==========================================
- Hits         9929     9921       -8     
  Misses        961      961              
Impacted Files Coverage Δ
esmvalcore/preprocessor/_regrid.py 97.11% <ø> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@sloosvel sloosvel self-requested a review October 11, 2022 07:26
Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry could you please update the documentation as well? There are still references to these schemes

@valeriupredoi
Copy link
Contributor Author

too true, good catch, Saskia 🐟 Done now!

@valeriupredoi
Copy link
Contributor Author

thanks a lot for the review, Saskia!

@valeriupredoi valeriupredoi merged commit 9dec201 into main Oct 11, 2022
@valeriupredoi valeriupredoi deleted the implement_deprecation branch October 11, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants