Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command line run documentation #721

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Jul 20, 2020

Before you start, please read our contribution guidelines.

Tasks

  • This pull request has a descriptive title that can be used in a changelog

@jvegreg jvegreg requested a review from bouweandela July 20, 2020 14:36
@mattiarighi
Copy link
Contributor

Shouldn't we document this also here?

@jvegreg
Copy link
Contributor Author

jvegreg commented Jul 20, 2020

Shouldn't we document this also here?

In that case I should add dlocumentation for all the parameters. I will do it tomorrow

@bouweandela
Copy link
Member

@jvegasbsc If you have time, could you please have a look at this?

@jvegreg jvegreg force-pushed the improve_doc_diag_filter branch from 63dc768 to fcf9b6f Compare October 1, 2020 10:27
@bouweandela
Copy link
Member

Related to #805. @jvegasbsc Is this ready for review now?

@jvegreg
Copy link
Contributor Author

jvegreg commented Oct 2, 2020

@jvegasbsc Is this ready for review now?

It is just documentation, so you can left this for the last minute, just in case I find a way to generate it automatically before monday

@jvegreg
Copy link
Contributor Author

jvegreg commented Oct 5, 2020

No way found, so please check and merge

@bouweandela bouweandela added the documentation Improvements or additions to documentation label Oct 5, 2020
@bouweandela bouweandela changed the title Improve doc of diagnostic filter Improve command line run documentation Oct 5, 2020
@bouweandela bouweandela merged commit a2e2167 into master Oct 5, 2020
@bouweandela bouweandela deleted the improve_doc_diag_filter branch October 5, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants