Updating gravity and fixing typos #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
requested review from
climbfuji,
cacraigucar,
mkavulich and
grantfirl
cacraigucar
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
It appears that the incorrect units in #11 were previously fixed
climbfuji
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new "scalar" gravitational acceleration standard name, and move the variable version into the
state_variablessection.I also fixed some typos and updated some other standard names as described in the
fix typosissue. I should note that one standard name was changed slightly more than what was described in the issue at a scientist's request.Fixes #39
Fixes #11