Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #11

Closed
cacraigucar opened this issue Apr 16, 2021 · 9 comments · Fixed by #45
Closed

fix typos #11

cacraigucar opened this issue Apr 16, 2021 · 9 comments · Fixed by #45

Comments

@cacraigucar
Copy link
Collaborator

cacraigucar commented Apr 16, 2021

x_wind: Horizontal wind in a direction perdendicular to y_wind

y_wind: Horizontal wind in a direction perdendicular to x_wind

"Perpendicular" is mistyped

Units for avogadro are "molecule mole-1", but will not match the current CAM definition (no change needed here)

@nusbaume
Copy link
Collaborator

Just double-checking that you meant Perpendicular?

@cacraigucar
Copy link
Collaborator Author

Just double-checking that you meant Perpendicular?

Yup - even my typo correction has a typo! I was concentrating so hard on the "d" to "p". The good news is that I typed it right when I put it into CAMDEN!

@cacraigucar
Copy link
Collaborator Author

constituent_mixing_ratio: Constituent mixing ratio
real(kind=kind_phys): units = kg/kg moist or dry air depending on type

Units should be "kg kg-1"

@cacraigucar
Copy link
Collaborator Author

cell_weight units should be "1"

@cacraigucar
Copy link
Collaborator Author

"pressure_dependent_XXX" needs to become "composition_dependent_XXX"

@nusbaume
Copy link
Collaborator

Also adding a note here that gravitational_acceleration should probably be moved from coordinates to constants.

@climbfuji
Copy link
Collaborator

gravitational_acceleration is not a constant. gravitational_constant is, but gravitational_acceleration depends on the distance from the center of the Earth.

@nusbaume
Copy link
Collaborator

Yeah we kept going back and forth on this, because although you are correct that gravity varies as a function of distance from the planet's center, our low and mid-top models treat it as a strict constant of ~9.81 m s-2.

Regardless, I am happy to move it to a different section in the standard names dictionary to indicate that it should change with height, at least in the real world. Would state_variables work?

I mostly don't want it in coordinates because it doesn't seem directly related to the geospatial grid itself. In other words if you output a physical quantity X to a NetCDF file it would seem weird (to me at least) to have its dimensions be X(lat, lon, gravity). That being said, if you have a counter example then I am happy to just keep it where it is.

@nusbaume
Copy link
Collaborator

Just leaving a note here that the discussion on gravitational_acceleration has been moved to issue #39.

nusbaume added a commit to nusbaume/CCPPStandardNames that referenced this issue Aug 10, 2023
mkavulich added a commit that referenced this issue Aug 28, 2023
Added a new "scalar" gravitational acceleration standard name, and move the variable version into the state_variables section.

I also fixed some typos and updated some other standard names as described in the fix typos issue. I should note that one standard name was changed slightly more than what was described in the issue at a scientist's request.

Fixes #39
Fixes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants