-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos #11
Comments
Just double-checking that you meant |
Yup - even my typo correction has a typo! I was concentrating so hard on the "d" to "p". The good news is that I typed it right when I put it into CAMDEN! |
constituent_mixing_ratio: Constituent mixing ratio Units should be "kg kg-1" |
cell_weight units should be "1" |
"pressure_dependent_XXX" needs to become "composition_dependent_XXX" |
Also adding a note here that |
|
Yeah we kept going back and forth on this, because although you are correct that gravity varies as a function of distance from the planet's center, our low and mid-top models treat it as a strict constant of ~9.81 m s-2. Regardless, I am happy to move it to a different section in the standard names dictionary to indicate that it should change with height, at least in the real world. Would I mostly don't want it in |
Just leaving a note here that the discussion on |
Added a new "scalar" gravitational acceleration standard name, and move the variable version into the state_variables section. I also fixed some typos and updated some other standard names as described in the fix typos issue. I should note that one standard name was changed slightly more than what was described in the issue at a scientist's request. Fixes #39 Fixes #11
x_wind: Horizontal wind in a direction perdendicular to y_wind
y_wind: Horizontal wind in a direction perdendicular to x_wind
"Perpendicular" is mistyped
Units for avogadro are "molecule mole-1", but will not match the current CAM definition (no change needed here)
The text was updated successfully, but these errors were encountered: