Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored to React/Redux #93

Merged
merged 68 commits into from
Mar 17, 2020
Merged

Refactored to React/Redux #93

merged 68 commits into from
Mar 17, 2020

Conversation

nelsonni
Copy link
Member

@nelsonni nelsonni commented Mar 12, 2020 •
edited
Loading

Includes:

  • All core functionality refactored to use React components
  • All state now managed using Redux store and reducers
  • New React components: CanvasComponent, CardComponent, Diff, DiffPickerDialog, Editor, FileExplorer, FilePickerDialog, FolderPicker, NewCardDialog, RenderTree, StackComponent
  • All testing migrated to Jest + Enzyme to allow for consistent assertion, manipulation, and traversal of React components
  • All linting has been migrated to TypeScript ESLint to improve code quality and maintain consistency

nelsonni and others added 30 commits May 8, 2019 11:20
@nelsonni
Update .travis.yml
7d8eb83
@nelsonni
Base electron-forge with webpack template
79fae1e
@nelsonni
TypeScript and ts-loader for webpack
f382afc
@nelsonni
React Baseline
d454cb6
@nelsonni
React with Redux for presentational components and Monaco Editor cards
684095f
@nelsonni
React presentation components, Ace Editor integration, and File Open …
dda57c2 
…scaffolding
@nelsonni
Fixed and updated test suites use Enzyme and DnD mocking
85d9955
@nelsonni
add @types/react-redux to provide type definitions for react-redux
a0b90a7
@nelsonni
minor tweaks to add parts of Redux store functionality
0b5d309
@nelsonni
typed implementation of Card drag-and-drop using Legacy Decorator API…
2587547 
… of React DnD library
@nelsonni
Redux store connected to React components
5ee0f57
@nelsonni
openFileDialog properly resolves multiple selected files to metadata
3e3b8fb
@nelsonni
Text to direct new contributors to add GItHub username to README
1c2b8d1
@jettseale
Tree and node react components for file explorer
43ddb3f
@nelsonni
Removed old dead code, updated components and Redux store
f910170
@nelsonni
VSCode preferences
9325d32
@nelsonni
React list items require keys for unique identification of elements
3dd95a5
@nelsonni
Example inclusion of Tree component for testing purposes
ef2097b
@nelsonni
Updated File IO and Handlers + unit tests
d769ef4
@nelsonni
Fixed FilePicker and Redux duck typing
c23eb20
@nelsonni
Updated clean script and git ignore for Jest code coverage
9d7ba80
@nelsonni
FilePicker updates to use metafile and io interfaces
b320069
@nelsonni
Removed old dead code from extractMetafile
fcc43da
@nelsonni
Git funct and tests for extractFromURL
aea0de2
@nelsonni
git.extractRepo function and tests
d3e9341
@nelsonni
DiffPicker component for initiating card diffing
3a0439a
@jettseale
Almost done with explorer.ts
3ab06ae
@jettseale
Merge branch 'feature/react-refactor' into reactFileExplorer
0e576f6
@nelsonni
Dynamic AceEditor mode importing
0c77aa5
@nelsonni
Jest and webpack config cleanup
51a677b
nelsonni and others added 14 commits March 3, 2020 11:23
@nelsonni
Jest config and test updates for ace-builds
0affac4
@jettseale
Merge branch 'feature/react-refactor' of https://github.com/EPICLab/s…
317c8b9 
…ynectic into reactFileExplorer
@nelsonni
Component testing can now use baseReduxMock
e8b8b60
@jettseale
Merge branch 'feature/react-refactor' of https://github.com/EPICLab/s…
d0e982c 
…ynectic into reactFileExplorer
@nelsonni
Simplified CanvasComponent unit tests
9afb053
@nelsonni
Fixed EditorComponent unit tests for AceEditor markers
a1acae5
@nelsonni
Updated CardComponent unit tests
0999659
@nelsonni
DiffPickerDialog tests include click, escape key, and event triggers
db9c99c
@jettseale
finished react file explorer
0292d52
@jettseale
fixed tests for file explorer
3eb8dd4
@jettseale
made changes requested in comments
1c19944
@nelsonni
Merge pull request #92 from EPICLab/reactFileExplorer
24f7542 
File Explorer component
@nelsonni
Updated Redux Store Mock for proper initialization
6b8c681
@nelsonni
Remove branch restrictions for running Travis CI jobs on PRs
381a385
@nelsonni nelsonni added the feature Feature requests or improvements label Mar 12, 2020
@nelsonni nelsonni requested a review from jettseale March 12, 2020 22:44
nelsonni added 8 commits March 12, 2020 16:05
@nelsonni
Updated dependency pathing, removed package-lock.json which is genera…
035cab5 
…ted by npm
@nelsonni
Fix for build errors caused by Travis CI pulling in the latest versio…
c19bd2f 
…n of packages, which included isomorphic-git v.1.3.0 since package.json listed this package as being compatible relative to ^0.72.1 and v.1.0.0 was an API breaking change
@nelsonni
Travis config updated to bump minimum version from 8 to 10 for node, …
5dd6435 
…based on isomorphic-git@1.3.0 requiring node version >=10
@nelsonni
Fix for ESLint rule no-mocks-import when using reduxStoreMock in Reac…
dbb2111 
…t Component tests
@nelsonni
Adding executableName to Electron-Forge configs, per error messages t…
fb590cb 
…racked on Travis CI
@nelsonni
Electron-Forge config clean-up and Windows platform configured for Tr…
113d12a 
…avis CI
@nelsonni
Travis CI config updates to update OSX to xcode11.3, temporarily allo…
c984509 
…w failures for Linux and Windows builds
@nelsonni
Forced merge from feature/react-refactor to development branch
772c340
@nelsonni nelsonni merged commit a4d3bde into development Mar 17, 2020
@nelsonni nelsonni deleted the feature/react-refactor branch March 17, 2020 04:11
This was referenced Mar 31, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jettseale jettseale Awaiting requested review from jettseale

Assignees
No one assigned
Labels
feature Feature requests or improvements
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonni @jettseale