Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Focus within Editor Card #78

Closed
nelsonni opened this issue May 24, 2019 · 1 comment
Closed

Content Focus within Editor Card #78

nelsonni opened this issue May 24, 2019 · 1 comment
Assignees
Labels
feature Feature requests or improvements wontfix

Comments

@nelsonni
Copy link
Member

To enable #77 for Editor cards, an extension to the current Editor class is required in order to cause the code content within an Editor card to scroll to specific line and add highlighting to that line. This method should take into account scroll bounds for beginning and end of files (i.e. so that we don't scroll off the edge of a file).

@nelsonni nelsonni added the feature Feature requests or improvements label May 24, 2019
@nelsonni nelsonni added this to the v0.9.0 (Annotations Project) milestone May 24, 2019
@nelsonni nelsonni self-assigned this May 24, 2019
@nelsonni
Copy link
Member Author

nelsonni commented Mar 31, 2020

This issue was originally drafted when Editor was a plain TypeScript Class, which inherited from an abstract template Card class. However, after refactoring the core to use React/Redux in #93, this issue can quickly be resolved through the use of forwardRef and ref objects being bubbled up from the AceEditor component (as described in securingsincity/react-ace#356), and using the following code to update the cursor location in editor:

editor.goToLine(3);

If this feature becomes necessary, we can begin implementing the underlying code. But for now, this is a wontfix issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests or improvements wontfix
Projects
None yet
Development

No branches or pull requests

1 participant