Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow codon table to be set in mikado prepare #426

Closed
swarbred opened this issue Feb 1, 2022 · 3 comments
Closed

Allow codon table to be set in mikado prepare #426

swarbred opened this issue Feb 1, 2022 · 3 comments

Comments

@swarbred
Copy link
Collaborator

swarbred commented Feb 1, 2022

The user selected codon usage table is currently only used in mikado serialise, therefore when CDS features are present in the mikado prepare input these are translated with the standard genetic code (even if an alt has been set) this results in models failing the validation and being removed

Would make sense for the selected codon table to be used in both serialise and prepare.

@swarbred
Copy link
Collaborator Author

swarbred commented Feb 1, 2022

NOTE This is an issue that will affect reat homology and reat prediction as in both cases models with CDS features are in the GFF input to prepare and there is no way to prevent the check for internal stops (at best strip_faulty_cds: true , will retain the model but then requires ORFs to be recalled)

@ljyanesm
Copy link
Collaborator

ljyanesm commented Jun 9, 2022

Dear @swarbred,

Can you confirm this is fixed in the main branch? There are 3 commits to this effect on that branch, if so. We can close this ticket once there's a new release.

Best,

@swarbred
Copy link
Collaborator Author

swarbred commented Jun 9, 2022

@ljyanesm Yes that's correct, thanks

gemygk pushed a commit that referenced this issue Jun 9, 2022
…rsions (#433)

fix: Allow codon table to be set in mikado prepare #426
fix: Mikado configuration file is invalid #431
fix: Pin marshmallow dependency versions on requirements.txt and environment.yml files
@ljyanesm ljyanesm closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants