Pivotal # 177647985: MD5 Calculation For Big Files #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from full read file for MD5 calculation to a buffered reader approach
Juan-EBI
reviewed
Apr 10, 2021
|
|
||
| val md5sum = BigInteger(CHECKSUM_SIGNUM, digest.digest()).toString(HEXADECIMAL_BASE) | ||
| return String.format("%32s", md5sum).replace(" ", "0") | ||
| } |
There was a problem hiding this comment.
fun md5(file: File): String {
val digest = MessageDigest.getInstance(MD5_ALGORITHM)
file.inputStream().buffered(BUFFER_SIZE).use { it.iterator().forEach(digest::update) }
return digest.digest().joinToString("") { "%02x".format(it) }
}
Maybe?
There was a problem hiding this comment.
Works like a charm! I knew there was a better way to write this. Nice comment 😁👍
Code review comments
Juan-EBI
approved these changes
Apr 12, 2021
jhoanmanuelms
added a commit
that referenced
this pull request
Apr 15, 2021
Feature: * Pivotal ID # 177304040: PT Submit Migration Operation (#362) Bugfix: * Pivotal ID # 177536825: Add handler for SubmissionNotFoundException to response with the correct http status code (#364) * Pivotal # 177647985: MD5 Calculation For Big Files (#366) * Pivotal ID #177756846: Allow to bypass toxic risk validation when QMRF-ID attribute (#370) Chore: * Pivotal ID #177423348: PMC integration test (#356) * Pivotal ID # 177413307: Report Submissions With Errors (#368) Co-authored-by: Juan <jcamilorada@ebi.ac.uk> Co-authored-by: Néstor Diaz <ndiaz@ebi.ac.uk>
jhoanmanuelms
added a commit
that referenced
this pull request
Apr 16, 2021
Feature: * Pivotal ID # 177304040: PT Submit Migration Operation (#362) Bugfix: * Pivotal ID # 177536825: Add handler for SubmissionNotFoundException to response with the correct http status code (#364) * Pivotal # 177647985: MD5 Calculation For Big Files (#366) * Pivotal ID #177756846: Allow to bypass toxic risk validation when QMRF-ID attribute (#370) Chore: * Pivotal ID #177423348: PMC integration test (#356) * Pivotal ID # 177413307: Report Submissions With Errors (#368) Co-authored-by: Juan <jcamilorada@ebi.ac.uk> Co-authored-by: Néstor Diaz <ndiaz@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/177647985
Switch from full read file for MD5 calculation to a buffered reader approach