Pivotal ID #177423348: PMC integration test #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…services into chore/pivotal-177423348-PMC-integration-test
| format.delimiter = TAB | ||
| format.comment = TSV_COMMENT | ||
| skipEmptyLines = false | ||
| private fun createParser(): CSVFormat { |
There was a problem hiding this comment.
Why are you removing these changes back? I think these are the fix for https://www.pivotaltracker.com/story/show/174642598 right?
There was a problem hiding this comment.
this is the reason uniVocity/univocity-parsers#454 now we will need to scape character quotes if we want then to be interpreted as quotes and not page tab quote, perhaps in the future we can change our quote character per something more strange as $%
| @@ -1 +1 @@ | |||
| coverage=1 | |||
| coverage=0 | |||
| return Retrofit.Builder() | ||
| .baseUrl("http://www.ft-loading.europepmc.org") | ||
| .baseUrl(properties.pmcBaseUrl) |
| internal const val ACC_NO = "S-123SUCCESS" | ||
| internal val SUB_ATTRIBUTE = Attribute("Title", "Submission title") | ||
|
|
||
| val submissionBody = jsonObj { |
There was a problem hiding this comment.
Perhaps these chould be in a separated factory file?
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) | ||
| @ContextConfiguration(classes = [PersistenceConfig::class]) | ||
| @ExtendWith(TemporaryFolderExtension::class) | ||
| internal class PmcSubmissionProcessorTest(private val tempFolder: TemporaryFolder) { |
| @@ -0,0 +1 @@ | |||
| that is the content | |||
There was a problem hiding this comment.
couldn't we just create these test files with the temporary folder extension?
There was a problem hiding this comment.
yes no point to add this a resource
…services into chore/pivotal-177423348-PMC-integration-test
jhoanmanuelms
added a commit
that referenced
this pull request
Apr 15, 2021
Feature: * Pivotal ID # 177304040: PT Submit Migration Operation (#362) Bugfix: * Pivotal ID # 177536825: Add handler for SubmissionNotFoundException to response with the correct http status code (#364) * Pivotal # 177647985: MD5 Calculation For Big Files (#366) * Pivotal ID #177756846: Allow to bypass toxic risk validation when QMRF-ID attribute (#370) Chore: * Pivotal ID #177423348: PMC integration test (#356) * Pivotal ID # 177413307: Report Submissions With Errors (#368) Co-authored-by: Juan <jcamilorada@ebi.ac.uk> Co-authored-by: Néstor Diaz <ndiaz@ebi.ac.uk>
jhoanmanuelms
added a commit
that referenced
this pull request
Apr 16, 2021
Feature: * Pivotal ID # 177304040: PT Submit Migration Operation (#362) Bugfix: * Pivotal ID # 177536825: Add handler for SubmissionNotFoundException to response with the correct http status code (#364) * Pivotal # 177647985: MD5 Calculation For Big Files (#366) * Pivotal ID #177756846: Allow to bypass toxic risk validation when QMRF-ID attribute (#370) Chore: * Pivotal ID #177423348: PMC integration test (#356) * Pivotal ID # 177413307: Report Submissions With Errors (#368) Co-authored-by: Juan <jcamilorada@ebi.ac.uk> Co-authored-by: Néstor Diaz <ndiaz@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/177423348