Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote To DEV #258

Merged
merged 32 commits into from
Aug 18, 2020
Merged

Promote To DEV #258

merged 32 commits into from
Aug 18, 2020

Conversation

jhoanmanuelms
Copy link
Contributor

Promote changes to DEV environment

Juan-EBI and others added 30 commits May 19, 2020 12:26
* Pivotal ID # 172620298: Submission Notification URL
* Pivotal ID # 172475752: Email Validation Signing Up
* Pivotal ID 172650484: Add support for folders in submission
* Pivotal ID # 169759546: Number of views metadata for each accession 
* Pivotal ID #  170598906:  refresh full support 
* Pivotal ID # 172122614: Improve Backend Error Messages
* Pivotal #ID 171570707: Verify Recaptcha During Sign Up
* Pivotal #Id: 172798038: Add support between the submitter and submission owner
* Pivotal ID # 172620298: Submission Notification URL
* Pivotal ID # 172475752: Email Validation Signing Up
* Pivotal ID 172650484: Add support for folders in submission
* Pivotal ID # 169759546: Number of views metadata for each accession 
* Pivotal ID #  170598906:  refresh full support 
* Pivotal ID # 172122614: Improve Backend Error Messages
* Pivotal #ID 171570707: Verify Recaptcha During Sign Up
* Pivotal #ID: 172798038: Add support between the submitter and submission owner
* Pivotal ID # 172476764: Refresh Interdatabase Support (#222)
* Pivotal ID # 172889138: Stats Increment Endpoint (#224)
* Pivotal-ID # 173213544: User and Groups files permissions (#225)
* Pivotal ID # 173213544 : User and Groups files permissions (#228)
* Pivotal ID # 173383085: Stats Performance Improvement (#230)
* Pivotal ID # 173361277: Excel File List Empty Attributes (#229)
* Pivotal ID # 173458080: Refresh Process Files Management
* Pivotal ID # 172435555: BioStudies Submissions Topic (#221)
- Create a script to configure a RabbitMQ server
- Optimize the gradle tasks and update it to use Kotlin DSL
- Add missing properties to application.yml and application-local.yml
- Improve documentation
- Ignore accessions that don't exist instead of failing
- Make the stats endpoints case insensitive
Validate project access tag at submission time
* Pivotal ID # 173569202: Empty Section Parent Cell

Improve excel reader:
- When all the cells in a row are empty, this will be interpreted as an empty line
- Remove empty elements from the end of a row
- Remove all empty rows starting at the last populated
- Add unit tests for these edge cases

* Pivotal ID # 173569202: Empty Section Parent Cell

Improve code base and unit tests
* Pivotal ID # 173457302: RelPath Calculation

In an accession with several number groups only the last will be used

* Pivotal ID # 173457302: RelPath Calculation

Improve regex
* Pivotal ID # 173750220: Author TSV Serialization

Fix serialization for subsections without accession

* Pivotal ID # 173750220: Author TSV Serialization

Improve test cases
* Pivotal ID # 172817960: Resubmit Notification
- Changes in the architecture to use queues instead of events for notifications
- Get the extended submission from the service instead of passing down the elements in the event
- Add logic to load different templates based on the submission version
- Create/update the RT ticket depending on its existence
- Add testing
- Remove unused code
- Update the handlers application properties file
- changed file api
- updated dependencies
- added new query to reduce overload
- removed transactional for submission submiter
* Pivotal ID # 172817960: Resubmit Notfication

- Create an extended user endpoint
- Use the endpoint to get the user information in the notifications side
* Pivotal ID # 172817960: Resubmit Notification

- Move security notifications to queues based mechanism
- Create an independent module to publish messages to the queues
- Move all the notifications logic to the notifications module
- Improve the handlers application configuration
- Remove unnecessary code related to the observable logic and unused events
- Fix broken tests and build
* simplified relpath calculation extrategy
jhoanmanuelms and others added 2 commits August 18, 2020 16:42
- Fix validation errors on project AccNo template
- Improve class readability
- Add unit tests
* separated submission and processing steps

* code review changes
@jhoanmanuelms jhoanmanuelms requested a review from Juan-EBI August 18, 2020 16:22
@jhoanmanuelms jhoanmanuelms self-assigned this Aug 18, 2020
@jhoanmanuelms jhoanmanuelms merged commit 714ccdf into dev Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants