pivotal-173792650: Replace base path for multiple absolute paths #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
Jul 14, 2020
|
|
||
| fun getSubmissionFolder(submission: ExtSubmission): Path = | ||
| basePath.resolve(SUBMISSION_PATH).resolve(submission.relPath) | ||
| fun getSubmissionFtpFolder(submissionRelPath: String): Path = |
There was a problem hiding this comment.
Silly detail but, don't these two methods fit in a single line?
| basepath: | ||
| submissionPath: | ||
| ftpPath: | ||
| magicPath: |
There was a problem hiding this comment.
Don't we need this property in the application's main config file?
Also, I didn't see it's being used in the code, only in the ApplicationProperties class but I assume it's the user magic folder? In any case, I think the property name can be improved or at least add a comment indicating what it's used for.
There was a problem hiding this comment.
ohh yes let me remove this one, is for future changes
| @@ -10,6 +10,7 @@ import org.springframework.context.annotation.Configuration | |||
| @Configuration | |||
| @EnableConfigurationProperties(ApplicationProperties::class) | |||
| internal class GeneralConfig { | |||
|
|
|||
Juan-EBI
deleted the
feature/pivotal-173792650-Replace-base-path-for-multiple-absolute-paths
branch
jhoanmanuelms
added a commit
that referenced
this pull request
Aug 18, 2020
Promote To DEV Features: * Pivotal ID # 172817960: Resubmit Notification (#234) * Pivotal ID # 173574802: Submissions Files Permissions (#235) * Pivotal ID # 174054535: Disable SuperUser In Request * Pivotal ID # 169837866: Async File Processing (#256) * Pivotal ID # 173792650: Replace Base Path For Multiple Absolute Paths (#239) * Pivotal ID # 174127719: Transaction Lock (#250) Bug Fixes: * Pivotal ID # 173611760: Improve Stats AccNo Handling (#237) * Pivotal ID # 173457329: Project Access Tag Validation (#232) * Pivotal ID # 173569202: Empty Section Parent Cell (#240) * Pivotal ID # 173213544: User files permissions (#242) * Pivotal ID # 173457302: RelPath Calculation (#244) * Pivotal ID # 173750220: Author TSV Serialization (#245) * Pivotal ID # 174316468: Project Refresh AccNo Template Validation (#257) * Pivotal ID # 171230259: Draft Creation Times Out For Big Submissions (#251) Chores: * Pivotal ID # 172435409: Remove Old Backend Dependencies (#238) * Pivotal ID # 174076301: Update PMC Api (#248) * Pivotal ID #174275642: Submission Loading Strategy (#254) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/173792650