Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert "cpuIsSixtyFourBit" setting to "pathUsePFxEightySix" for people upgrading. #189

Closed
DrewNaylor opened this issue Sep 26, 2020 · 2 comments
Closed

Convert "cpuIsSixtyFourBit" setting to "pathUsePFxEightySix" for people upgrading. #189

DrewNaylor opened this issue Sep 26, 2020 · 2 comments
Labels
don't add to changelog Don't add this issue to the changelog; it's... irrelevant.
Milestone
Version 4.0 Coden...

Comments

@DrewNaylor
Copy link
Owner

There's a thing in .NET that allows this.
@DrewNaylor DrewNaylor added this to the Version 3.4 milestone Sep 26, 2020
@DrewNaylor DrewNaylor mentioned this issue Sep 26, 2020
Merged
DrewNaylor added a commit that referenced this issue Sep 26, 2020
@DrewNaylor
Merge pull request #190 from DrewNaylor/NewOptionsWindowControlText
3406f0d 
Options window controls text and functionality update.

Many controls in the Options window have had their text changed, and in one case, their functionality completely replaced.

Fixes #183. Fixes #184. Fixes #73.

Changed:
- Switched the tabs for `Bypass configured location` and the Office drive location (now simply `Root drive path`)
- Instead of requiring users to type in the drive letter they installed Office to, they can now select it from a dropdown of all drives that are "ready". If they change the drive letter manually in the config file, it'll show up in the list, but changing it to something else and saving settings will get rid of it. Please be aware that this means arbitrary drive letters can no longer be placed into the drive letter box as only drives Windows determines as "ready" are available. This is what was originally intended, so it's no big loss.
- Controls and groupboxes have been resized and repositioned so they look better.
- Now the `Enable Office 365/Click-to-Run Compatibility` checkbox is hidden if Office 2019 is selected, since it's irrelevant for that version.
- Tab text update:
  - `General` has been renamed to `Versions + Compatibility`
  - `Advanced` has been renamed to `Root Path`
- `Enable Office 365/Click-to-Run Compatibility` checkbox has been changed to `Enable Office 365/Click-to-Run Compatibility [line break]
 (Always enabled for Office 2019 and above)`
- Since 64-bit Office is the default for Office 2019 when downloaded from the Office website, there were changes in the `Root Path` tab:
  - `64-bit Windows` is now `Program Files (x86): 32-bit Office on 64-bit Windows`
  - `32-bit Windows` is now `Program Files: 64-bit Office on 64-bit Windows, [line break]
32-bit Office on 32-bit Windows, or 32-bit Office 2013 from Office 365`
  - `Program Files...` is the new default, since 64-bit Office is now the default download as mentioned above.
  - The description and recommended selection labels have been updated to accommodate this change.
- `My.Settings.cpuIsSixtyFourBit` has been changed to `My.Settings.pathUsePFxEightySix` to reflect what it's really for. For those upgrading from an older version, there will be a thing that migrates this specific setting to the new setting. See #189.
- Instead of using `32-bit Mode` or `64-bit Mode` in the titlebar, we'll now display `PF Mode` or `PF-x86 Mode` since that's more accurate to what's going on.
- Settings defaults changes:
  - Default Office version has been changed to Office 2019/`16nomsi`
  - Default Program Files path setting has been changed to Program Files/`My.Settings.pathUsePFxEightySix = False`
- The strings with "private" in their names that were used in the Office Locater code have been removed and the public strings are being modified instead. This'll help optimize things.

Removed:
- Deleted the future change notice code since it's implemented now.
@DrewNaylor
Copy link
Owner Author

This might help.
https://docs.microsoft.com/en-us/dotnet/api/system.configuration.applicationsettingsbase.getpreviousversion?view=netframework-4.6.1

@DrewNaylor DrewNaylor changed the title Convert "cpuIsSixtyFourBit" setting to "modeUsePFxEightySix" for people upgrading. Convert "cpuIsSixtyFourBit" setting to "pathUsePFxEightySix" for people upgrading. Oct 2, 2020
@DrewNaylor
Copy link
Owner Author

Didn't work since you can't rename settings across versions like this.

@DrewNaylor DrewNaylor added the don't add to changelog Don't add this issue to the changelog; it's... irrelevant. label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
don't add to changelog Don't add this issue to the changelog; it's... irrelevant.
Projects
None yet
Milestone
Version 4.0 Codename "Changeth Arrang...
Development

No branches or pull requests
1 participant
@DrewNaylor