Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Options window tabs. #183

Closed
DrewNaylor opened this issue Jul 26, 2020 · 3 comments · Fixed by #190
Closed

Renaming Options window tabs. #183

DrewNaylor opened this issue Jul 26, 2020 · 3 comments · Fixed by #190
Labels
on changelog The labeled issue is on the changelog for the next version. options and settings

Comments

@DrewNaylor
Copy link
Owner

"General" will become "Versions + Editions", and "Advanced" will become "Drives + Paths"

The "paths" part will need to have it mentioned that the apps bypassing the configured location are the ones that are in the user's PATH.

"Editions" is a result of moving the Windows edition groupbox to the tab with Office versions.

@DrewNaylor
Copy link
Owner Author

DrewNaylor commented Jul 26, 2020

Maybe it could just be "Versions" and "Paths", as a drive is a path and x86 or x86_64 editions of Windows could be considered versions.

@DrewNaylor
Copy link
Owner Author

"Versions + Architectures" would work better.

@DrewNaylor
Copy link
Owner Author

The tabs have been renamed to "Versions + Compatibility" and "Root Path".

DrewNaylor added a commit that referenced this issue Sep 26, 2020
Options window controls text and functionality update.

Many controls in the Options window have had their text changed, and in one case, their functionality completely replaced.

Fixes #183. Fixes #184. Fixes #73.

Changed:
- Switched the tabs for `Bypass configured location` and the Office drive location (now simply `Root drive path`)
- Instead of requiring users to type in the drive letter they installed Office to, they can now select it from a dropdown of all drives that are "ready". If they change the drive letter manually in the config file, it'll show up in the list, but changing it to something else and saving settings will get rid of it. Please be aware that this means arbitrary drive letters can no longer be placed into the drive letter box as only drives Windows determines as "ready" are available. This is what was originally intended, so it's no big loss.
- Controls and groupboxes have been resized and repositioned so they look better.
- Now the `Enable Office 365/Click-to-Run Compatibility` checkbox is hidden if Office 2019 is selected, since it's irrelevant for that version.
- Tab text update:
  - `General` has been renamed to `Versions + Compatibility`
  - `Advanced` has been renamed to `Root Path`
- `Enable Office 365/Click-to-Run Compatibility` checkbox has been changed to `Enable Office 365/Click-to-Run Compatibility [line break]
 (Always enabled for Office 2019 and above)`
- Since 64-bit Office is the default for Office 2019 when downloaded from the Office website, there were changes in the `Root Path` tab:
  - `64-bit Windows` is now `Program Files (x86): 32-bit Office on 64-bit Windows`
  - `32-bit Windows` is now `Program Files: 64-bit Office on 64-bit Windows, [line break]
32-bit Office on 32-bit Windows, or 32-bit Office 2013 from Office 365`
  - `Program Files...` is the new default, since 64-bit Office is now the default download as mentioned above.
  - The description and recommended selection labels have been updated to accommodate this change.
- `My.Settings.cpuIsSixtyFourBit` has been changed to `My.Settings.pathUsePFxEightySix` to reflect what it's really for. For those upgrading from an older version, there will be a thing that migrates this specific setting to the new setting. See #189.
- Instead of using `32-bit Mode` or `64-bit Mode` in the titlebar, we'll now display `PF Mode` or `PF-x86 Mode` since that's more accurate to what's going on.
- Settings defaults changes:
  - Default Office version has been changed to Office 2019/`16nomsi`
  - Default Program Files path setting has been changed to Program Files/`My.Settings.pathUsePFxEightySix = False`
- The strings with "private" in their names that were used in the Office Locater code have been removed and the public strings are being modified instead. This'll help optimize things.

Removed:
- Deleted the future change notice code since it's implemented now.
@DrewNaylor DrewNaylor added the on changelog The labeled issue is on the changelog for the next version. label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on changelog The labeled issue is on the changelog for the next version. options and settings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant