NEW Add possibility to choose format #21426 #23509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… choose between utf-8 and iso format
eldy
reviewed
Jan 11, 2023
| /** | ||
| * Class to build export files with format CSV | ||
| */ | ||
| class ExportCsvUtf8 extends ModeleExports |
There was a problem hiding this comment.
It seems this class is a copy of the class for iso but with just few lines changed.
So why not don't you make an inherit
class ExportCsvUtf8 extends ExportCsv
And implement into class only properties or method with change for utf8 ?
eldy
added
the
PR to fix - See feedback in comments
|
Still travis error. Try to move the set of the CHARSET... into an surcharging method write_record, ... instead of into constructor. |
|
Unit test to fix |
… files to override the write_title and write_record functions to initialize EXPORT_CSV_FORCE_CHARSET
Hystepik
added
PR to fix - OK to merge if suggested fix are done
…adds an export type when choosing the export type
Hystepik
removed
the
PR to fix - OK to merge if suggested fix are done
Hystepik
added
the
PR OK to merge
|
@eldy seams ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW|New feature(#21426) Added in the export module the possibility to choose between utf-8 and iso format