Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During the export of a CSV, allow the user to choose between file format ISO-8859-1 or UTF8 #21426

Closed
eldy opened this issue Jul 1, 2022 · 0 comments
Closed

During the export of a CSV, allow the user to choose between file format ISO-8859-1 or UTF8 #21426

eldy opened this issue Jul 1, 2022 · 0 comments
Assignees
@KiVoilaJe
Labels
Feature request This is a feature request good-first-issue This is a good issue to try make your first PR if you don't know very well the project hacktoberfest This is a good issue to try make your first PR if you don't know very well the project hacktoberfest-accepted This is added to a PR accepted for the hacktoberfest session (Flag added by core team only)

Comments

@eldy
Copy link
Member

eldy commented Jul 1, 2022 •
edited
Loading

Feature Request

There is already an option called EXPORT_CSV_FORCE_CHARSET into the tool that generate the CSV file.
Instead of using a fixed hidden option, we must ask the user with a combo of 2 choices;
UTF-8
ISO-8859-1

For the CSV, ask ask also for the separator: Ask for
,
;
Must be preselected to the constant EXPORT_CSV_SEPARATOR_TO_USE
@eldy eldy added Feature request This is a feature request hacktoberfest This is a good issue to try make your first PR if you don't know very well the project good-first-issue This is a good issue to try make your first PR if you don't know very well the project labels Jul 1, 2022
@badre-agtaib badre-agtaib removed their assignment Oct 27, 2022
KiVoilaJe pushed a commit to KiVoilaJe/dolibarr that referenced this issue Jan 11, 2023
feature(Dolibarr#21426) Added in the export module the possibility to…
1c659c6 
… choose between utf-8 and iso format
@KiVoilaJe KiVoilaJe mentioned this issue Jan 11, 2023
Merged
KiVoilaJe pushed a commit to KiVoilaJe/dolibarr that referenced this issue Feb 16, 2023
feature (Dolibarr#21426) edit ExportTest for resolve error and add te…
c000eee 
…st for utf8
KiVoilaJe pushed a commit to KiVoilaJe/dolibarr that referenced this issue Feb 22, 2023
fix (Dolibarr#21426) edit file name of export_csv.modules because it …
cfe6ebf 
…adds an export type when choosing the export type
eldy added a commit that referenced this issue Apr 18, 2023
@eldy
Merge pull request #23509 from FliyFly/feature#21426
6ab05df 
NEW Add possibility to choose format #21426
KiVoilaJe pushed a commit to KiVoilaJe/dolibarr that referenced this issue Jun 13, 2023
NEW Add possibility to choose separator Dolibarr#21426
4c032f8
@KiVoilaJe KiVoilaJe mentioned this issue Jun 13, 2023
Merged
eldy added a commit that referenced this issue Aug 30, 2023
@eldy
Merge pull request #25084 from FliyFly/feature2#21426
9ce9eac 
NEW Add possibility to choose separator #21426
@eldy eldy closed this as completed Oct 17, 2023
@eldy eldy added the hacktoberfest-accepted This is added to a PR accepted for the hacktoberfest session (Flag added by core team only) label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KiVoilaJe KiVoilaJe

Labels
Feature request This is a feature request good-first-issue This is a good issue to try make your first PR if you don't know very well the project hacktoberfest This is a good issue to try make your first PR if you don't know very well the project hacktoberfest-accepted This is added to a PR accepted for the hacktoberfest session (Flag added by core team only)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eldy @KiVoilaJe @badre-agtaib