Upgrade ember-auto-import to v2 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks great! I'm going to merge it. If we're going to bump version because of ember-auto-import it's good that we also drop node 10. |
|
@SergeAstapov is there anything else you found should be updated before I cut v4? |
|
@cibernox @snewcomer we should delete now deprecated I'll create PR later today. |
|
That sounds great! Lmk if you need any help |
|
@snewcomer I've done mixin clean up and it appear quite a bunch of tests related to it. So I'm working on fixing tests and it will take few more days. |
snewcomer
added
dependencies
SergeAstapov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #283 and has two breaking changes:
package.json's engine propertyPer ember-auto-import 1.x to 2.x migration guide:
There is a bunch of wins (especially performance) for apps that update to e-a-i v2 and e-a-i v2 will be a hard requirement for apps to run Ember v4 (which should not be big deal as apps running v2 should be able to use addons running e-a-i v1, but why not).
There is great write up from @buschtoens about this https://twitter.com/buschtoens/status/1449745386571247620