Skip to content

Commit

Permalink
Merge pull request #285 from SergeAstapov/ember-auto-import-v2
Browse files Browse the repository at this point in the history
[Breaking] Upgrade ember-auto-import to v2
  • Loading branch information
cibernox authored Oct 19, 2021
2 parents 12d81bd + 3f2538e commit 2727354
Show file tree
Hide file tree
Showing 17 changed files with 8,226 additions and 34,798 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# misc
/coverage/
!.*
.*/
.eslintcache

# ember-try
Expand Down
29 changes: 14 additions & 15 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,15 @@ module.exports = {
// node files
{
files: [
'.eslintrc.js',
'.prettierrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
'index.js',
'testem.js',
'blueprints/*/index.js',
'config/**/*.js',
'tests/dummy/config/**/*.js',
],
excludedFiles: [
'addon/**',
'addon-test-support/**',
'app/**',
'tests/dummy/app/**',
'./.eslintrc.js',
'./.prettierrc.js',
'./.template-lintrc.js',
'./ember-cli-build.js',
'./index.js',
'./testem.js',
'./blueprints/*/index.js',
'./config/**/*.js',
'./tests/dummy/config/**/*.js',
],
parserOptions: {
sourceType: 'script',
Expand All @@ -55,5 +49,10 @@ module.exports = {
plugins: ['node'],
extends: ['plugin:node/recommended'],
},
{
// Test files:
files: ['tests/**/*-test.{js,ts}'],
extends: ['plugin:qunit/recommended'],
},
],
};
113 changes: 56 additions & 57 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,73 +3,72 @@ name: CI
on:
push:
branches:
- main
- master
pull_request: {}

jobs:

lint:
name: "Lint"
env:
CI: true
test:
name: "Tests"
runs-on: ubuntu-latest
strategy:
fail-fast: true

steps:
- uses: actions/checkout@v2
- name: Install node
uses: actions/setup-node@v2-beta
with:
node-version: 12.x
- uses: actions/checkout@v2
- name: Install Node
uses: actions/setup-node@v2
with:
node-version: 12.x
cache: npm
- name: Install Dependencies
run: npm ci
- name: Lint
run: npm run lint
- name: Run Tests
run: npm run test:ember

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"
floating:
name: "Floating Dependencies"
runs-on: ubuntu-latest

- uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: yarn install
run: yarn
- name: lint
run: yarn lint
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 12.x
cache: npm
- name: Install Dependencies
run: npm install --no-shrinkwrap
- name: Run Tests
run: npm run test:ember

floating:
name: "Floating dependencies"
env:
CI: true
try-scenarios:
name: ${{ matrix.try-scenario }}
runs-on: ubuntu-latest
needs: 'test'

strategy:
fail-fast: true
fail-fast: false
matrix:
try-scenario: [
ember-lts-3.16,
ember-lts-3.20,
# ember-beta,
# ember-default-with-jquery,
# ember-classic
]
steps:
- uses: actions/checkout@v2
- name: Install node
uses: actions/setup-node@v2-beta
with:
node-version: 12.x
try-scenario:
- ember-lts-3.16
- ember-lts-3.20
- ember-lts-3.24
- ember-release
- ember-beta
- ember-canary
- ember-classic
- ember-default-with-jquery
- embroider-safe
- embroider-optimized

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"

- uses: actions/cache@v2
with:
path: ${{ steps.yarn-cache.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: yarn install
run: yarn
- name: test
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
steps:
- uses: actions/checkout@v2
- name: Install Node
uses: actions/setup-node@v2
with:
node-version: 12.x
cache: npm
- name: Install Dependencies
run: npm ci
- name: Run Tests
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
1 change: 1 addition & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
/ember-cli-build.js
/testem.js
/tests/
/yarn-error.log
/yarn.lock
.gitkeep

Expand Down
2 changes: 2 additions & 0 deletions addon/mixins/in-viewport.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ export default Mixin.create({
false,
{
id: 'ember-in-viewport.mixin',
for: 'ember-in-viewport',
since: '3.7.7',
until: '4.0.0',
url: 'https://github.com/DockYard/ember-in-viewport#readme',
}
Expand Down
13 changes: 12 additions & 1 deletion config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = async function () {
name: 'ember-lts-3.16',
npm: {
devDependencies: {
'ember-source': '~3.16.0',
'ember-source': '~3.16.10',
},
},
},
Expand All @@ -22,6 +22,14 @@ module.exports = async function () {
},
},
},
{
name: 'ember-lts-3.24',
npm: {
devDependencies: {
'ember-source': '~3.24.3',
},
},
},
{
name: 'ember-release',
npm: {
Expand Down Expand Up @@ -69,6 +77,9 @@ module.exports = async function () {
}),
},
npm: {
devDependencies: {
'ember-source': '~3.28.0',
},
ember: {
edition: 'classic',
},
Expand Down
8 changes: 7 additions & 1 deletion ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,11 @@ module.exports = function (defaults) {
*/

const { maybeEmbroider } = require('@embroider/test-setup');
return maybeEmbroider(app);
return maybeEmbroider(app, {
skipBabel: [
{
package: 'qunit',
},
],
});
};
Loading

0 comments on commit 2727354

Please sign in to comment.