Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting CI #15

Merged
merged 7 commits into from
Feb 5, 2022
Merged

Starting CI #15

merged 7 commits into from
Feb 5, 2022

Conversation

rcaneill
Copy link
Collaborator

@rcaneill rcaneill commented Feb 2, 2022

I don't know how to test the CI before merging and doing a fake PR to test it.
If you know how to do (or know a somewhere where they describe it), feel free to do it / tell me (I'll also try to search the answer online whenever I have time).

@rcaneill
Copy link
Collaborator Author

rcaneill commented Feb 2, 2022

Oh that's magic, github is runing the CI :D, sweet

poetry install
- name: Test with pytest
run: |
/home/$HOME/.poetry/bin/poetry run pytest gsw_xarray/tests
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, this does not work... It seems that poetry is not found...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poetry seems popular enough that there is probably some gh action we can use to deal with most of it.. I'm getting 500 errors on the gh marketplace so cannot really look

@rcaneill
Copy link
Collaborator Author

rcaneill commented Feb 3, 2022

I am not sure that we need to test buikd / test for both macOS and linux, for 3 python versions.
Github provides 2000 free minutes per month (1 windows minute counts for 2 minutes, 1 macOS minute counts for 10), so I guess that if we reach this limit we can think about reducing the number of tested versions.

@rcaneill
Copy link
Collaborator Author

rcaneill commented Feb 3, 2022

python 3.10 does not pass the tests, it seems to be a pytest error (see error) but I don't really understand what it is now. I'll search it if I have time today.

pyproject.toml Show resolved Hide resolved
@rcaneill rcaneill requested a review from DocOtak February 3, 2022 12:23
@DocOtak DocOtak merged commit 17540f6 into master Feb 5, 2022
@DocOtak DocOtak deleted the rcaneill-issue13 branch February 17, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants