-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting CI #15
Starting CI #15
Conversation
Oh that's magic, github is runing the CI :D, sweet |
.github/workflows/ci.yml
Outdated
poetry install | ||
- name: Test with pytest | ||
run: | | ||
/home/$HOME/.poetry/bin/poetry run pytest gsw_xarray/tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, this does not work... It seems that poetry is not found...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poetry seems popular enough that there is probably some gh action we can use to deal with most of it.. I'm getting 500 errors on the gh marketplace so cannot really look
I am not sure that we need to test buikd / test for both macOS and linux, for 3 python versions. |
python 3.10 does not pass the tests, it seems to be a pytest error (see error) but I don't really understand what it is now. I'll search it if I have time today. |
I don't know how to test the CI before merging and doing a fake PR to test it.
If you know how to do (or know a somewhere where they describe it), feel free to do it / tell me (I'll also try to search the answer online whenever I have time).