-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI testing / black (?) / flake8 / isort (?) #13
Comments
(This is maybe not urgent for the v0.2.0, we could keep it for later. If you think that it is essential, I let you add this issue to the milestone version 0.2.0) |
CI with test done in PR #15, so what is left is black / flake8 / isort |
Pre-commit + CI checks for style/black? I've never used isort, but did see when xarray was first adding it, they excluded it from the normal CI checks and just manually ran it occasionally. Not sure what the current status over there is. |
We should use the github actions to have a CI for the tests.
We can discuss whether to format the code with black (common within xarray community), verify with flake8 the coding style, and use isort to automatically sort the imports.
The text was updated successfully, but these errors were encountered: