Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI testing / black (?) / flake8 / isort (?) #13

Closed
rcaneill opened this issue Feb 1, 2022 · 3 comments · Fixed by #71
Closed

CI testing / black (?) / flake8 / isort (?) #13

rcaneill opened this issue Feb 1, 2022 · 3 comments · Fixed by #71
Milestone

Comments

@rcaneill
Copy link
Collaborator

rcaneill commented Feb 1, 2022

We should use the github actions to have a CI for the tests.

We can discuss whether to format the code with black (common within xarray community), verify with flake8 the coding style, and use isort to automatically sort the imports.

@rcaneill
Copy link
Collaborator Author

rcaneill commented Feb 1, 2022

(This is maybe not urgent for the v0.2.0, we could keep it for later. If you think that it is essential, I let you add this issue to the milestone version 0.2.0)

@rcaneill rcaneill added this to the Version 0.2.1 milestone Feb 5, 2022
@rcaneill
Copy link
Collaborator Author

rcaneill commented Feb 5, 2022

CI with test done in PR #15, so what is left is black / flake8 / isort

@DocOtak
Copy link
Owner

DocOtak commented Feb 5, 2022

Pre-commit + CI checks for style/black? I've never used isort, but did see when xarray was first adding it, they excluded it from the normal CI checks and just manually ran it occasionally. Not sure what the current status over there is.

@rcaneill rcaneill modified the milestones: Version 0.2.1, Version 0.3.1 Mar 23, 2022
@rcaneill rcaneill modified the milestones: Version 0.3.1, Version 1.0.0 Nov 29, 2022
@rcaneill rcaneill linked a pull request Nov 27, 2023 that will close this issue
@rcaneill rcaneill modified the milestones: Version 1.0.0, Version 0.4.0 May 10, 2024
@rcaneill rcaneill linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants