This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
fix(default-theme): fix for scrolling page after closing cart #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/4mvlou4yh |
|
💙 shopware-pwa-canary successfully deployed at https://9dd52972ca849e1cf0a26dae30959bd963a31168.shopware-pwa-canary.preview.storefrontcloud.io |
|
A bit wonky. If the side-effect is given by SfSidebar component (as this is my understanding of the situation) then it should be fixed in SfSidebar. Edit: saw the TODO |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix for scrolling page after closing the cart sidebar.
closes #915 closes #1081
Checklist