Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

[BUG] No scrolling after opening cart #1081

Closed
mothership-nik-wolf opened this issue Sep 10, 2020 · 1 comment · Fixed by #1082
Closed

[BUG] No scrolling after opening cart #1081

mothership-nik-wolf opened this issue Sep 10, 2020 · 1 comment · Fixed by #1082
Assignees
Labels
bug Something isn't working

Comments

@mothership-nik-wolf
Copy link
Contributor

Describe the bug

When opening the cart in the latest stable version, it's not possible to scroll the site after closing the cart.
Steps to reproduce:

  1. Install shopware-pwa stable with shopware-cli
  2. shopware-pwa dev
  3. Add a product to the cart
  4. open and close the cart
  5. No more scrollbar and scrolling not possible

Additional context

It happens because the body-node gets "overflow: hidden;" set as inline-style when opening the cart. But the style does not get reset when closing the cart.

@mothership-nik-wolf mothership-nik-wolf added the bug Something isn't working label Sep 10, 2020
@mothership-nik-wolf
Copy link
Contributor Author

mothership-nik-wolf commented Sep 10, 2020

Seems like this was resolved way back in Oct. 2019 in storefront-ui: https://github.com/DivanteLtd/storefront-ui/pull/368/files#diff-bc3fce3e23c0fbf9c8f016b1832ee04fR63

It should be handled here (https://github.com/DivanteLtd/storefront-ui/blob/develop/packages/vue/src/components/organisms/SfSidebar/SfSidebar.vue#L139) as I understand it, but something is broken :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants