Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send mount event when hydrating #1764

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Send mount event when hydrating #1764

merged 1 commit into from
Dec 30, 2023

Conversation

hampuslidin
Copy link
Contributor

Resolves #1763.

@ealmloff ealmloff added fullstack related to the fullstack crate bug Something isn't working labels Dec 30, 2023
@hampuslidin
Copy link
Contributor Author

This will conflict with #1732, so this code needs to adapt to that PR. Most notably, the set_node JS function binding has been replaced with hydrate, which handles all the hydration in one go, as well as creating event listeners. I assume it will incorrectly create an event listener for the "mount" event, instead of firing it, which is what this PR solves.

ealmloff
ealmloff approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now, I can fix the conflicts in #1732. Thank you!

Fixed in 0a7873f

@ealmloff ealmloff merged commit 0166eaf into DioxusLabs:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fullstack related to the fullstack crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mounted event is not triggered in fullstack renderer
2 participants
@hampuslidin @ealmloff