Make hydration more resilient #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
enhancement
ealmloff
force-pushed
the
resilient-hydration
branch
from
407f3cb to
b7aea96
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the process of hydration to make it more resilient to changes the browser might make to the structure of nodes. The old version of hydration used the structure of the dom to hydrate each node. The new version uses a set of predefined ids to hydrate nodes instead. That means that the page should still hydrate correctly even if the nodes are moved around before hydration.
Closes #1717
Closes DioxusLabs/docsite#91
Closes DioxusLabs/docsite#139
TODO: