Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recycling nodes in native core #1363

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Aug 15, 2023

When node ids are reused native core should assume that the node that was previously at the id should be removed.
Partially Fixes #1361

@ealmloff ealmloff added bug Something isn't working native Related to dioxus-native labels Aug 15, 2023
@ealmloff ealmloff marked this pull request as draft August 15, 2023 14:46
@ealmloff ealmloff marked this pull request as ready for review August 15, 2023 15:37
@jkelleyrtp jkelleyrtp merged commit 544ca55 into DioxusLabs:master Dec 8, 2023
@ealmloff ealmloff deleted the fix-native-core-leak branch December 8, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working native Related to dioxus-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Potential memory leak (maybe just on native-core)
2 participants