Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dioxus 0.5 support #346

Merged
merged 92 commits into from
Feb 6, 2024
Merged

feat: Dioxus 0.5 support #346

merged 92 commits into from
Feb 6, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Oct 21, 2023

Closes #468

Builds on DioxusLabs/dioxus#1791

@marc2332 marc2332 added enhancement 🔥 New feature or request dioxus🧬 Related to dioxus APIs labels Oct 21, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 839 lines in your changes are missing coverage. Please review.

Comparison is base (32dc45b) 53.17% compared to head (7c2d31d) 53.17%.

Files Patch % Lines
...components/src/scroll_views/virtual_scroll_view.rs 0.00% 86 Missing ⚠️
crates/components/src/scroll_views/scroll_view.rs 0.00% 78 Missing ⚠️
crates/components/src/dropdown.rs 0.00% 70 Missing ⚠️
crates/components/src/slider.rs 0.00% 61 Missing ⚠️
crates/components/src/input.rs 0.00% 54 Missing ⚠️
crates/devtools/src/lib.rs 0.00% 45 Missing ⚠️
crates/components/src/table.rs 0.00% 39 Missing ⚠️
crates/components/src/switch.rs 0.00% 34 Missing ⚠️
crates/components/src/accordion.rs 0.00% 33 Missing ⚠️
crates/components/src/button.rs 0.00% 32 Missing ⚠️
... and 37 more
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #346    +/-   ##
========================================
  Coverage   53.17%   53.17%            
========================================
  Files         148      151     +3     
  Lines       13113    13233   +120     
========================================
+ Hits         6973     7037    +64     
- Misses       6140     6196    +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 2, 2024

Benchmark for 40e672c

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 32.2±0.50ms 31.9±0.83ms -0.93%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1605.9±18.10µs 1992.2±29.10µs +24.06%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 153.3±1.39µs 151.8±12.43µs -0.98%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.6±0.30ms 26.1±0.15ms -1.88%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.53ms 2.8±0.60ms +3.70%
benchmarks/size=19531 depth=7 wide=5 mode=cached 562.3±25.94µs 621.6±38.34µs +10.55%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.5±0.13ms 4.0±0.16ms +14.29%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 445.8±26.97µs 438.9±74.08µs -1.55%
benchmarks/size=54241 depth=5 wide=15 mode=cached 653.4±28.25µs 629.1±25.43µs -3.72%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.5±0.25ms 7.3±0.14ms -2.67%

Copy link

github-actions bot commented Feb 2, 2024

Benchmark for 09334a4

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.5±0.37ms 30.3±1.50ms -0.66%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1583.6±17.08µs 1585.5±9.62µs +0.12%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 151.3±1.25µs 150.4±1.28µs -0.59%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.3±0.60ms 25.4±0.28ms +0.40%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.55ms 2.7±0.56ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 674.7±185.25µs 507.0±14.24µs -24.86%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.4±0.11ms 3.2±0.07ms -5.88%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 444.6±49.40µs 449.8±72.12µs +1.17%
benchmarks/size=54241 depth=5 wide=15 mode=cached 643.2±20.05µs 648.1±101.29µs +0.76%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.3±0.18ms 7.3±0.06ms 0.00%

Copy link

github-actions bot commented Feb 2, 2024

Benchmark for a170254

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 31.7±0.72ms 30.7±1.12ms -3.15%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1632.1±15.09µs 1581.3±27.33µs -3.11%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 155.3±1.21µs 148.7±1.24µs -4.25%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.0±0.25ms 26.3±0.56ms +1.15%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.9±0.50ms 2.7±0.52ms -6.90%
benchmarks/size=19531 depth=7 wide=5 mode=cached 602.5±34.13µs 596.7±33.71µs -0.96%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.8±0.23ms 3.9±0.20ms +2.63%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 444.8±41.02µs 436.1±3.43µs -1.96%
benchmarks/size=54241 depth=5 wide=15 mode=cached 652.3±28.65µs 678.1±104.38µs +3.96%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.5±0.15ms 7.8±0.23ms +4.00%

Copy link

github-actions bot commented Feb 5, 2024

Benchmark for 9a6f91f

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 32.0±0.35ms 32.0±0.74ms 0.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1618.6±114.86µs 1587.6±38.73µs -1.92%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 152.2±1.26µs 149.8±1.64µs -1.58%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.3±1.37ms 26.6±0.28ms -2.56%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.8±0.59ms 2.9±0.50ms +3.57%
benchmarks/size=19531 depth=7 wide=5 mode=cached 757.3±67.00µs 588.3±53.82µs -22.32%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 4.0±0.23ms 3.6±0.20ms -10.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 447.6±90.20µs 443.9±63.97µs -0.83%
benchmarks/size=54241 depth=5 wide=15 mode=cached 675.0±36.63µs 642.5±140.93µs -4.81%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.4±0.13ms 7.2±0.25ms -2.70%

Copy link

github-actions bot commented Feb 6, 2024

Benchmark for 324ef80

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 31.2±0.53ms 31.2±0.85ms 0.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1995.4±26.28µs 1589.9±27.08µs -20.32%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 151.5±2.33µs 152.2±6.90µs +0.46%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.8±0.26ms 26.0±0.24ms +0.78%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.8±0.55ms 2.7±0.57ms -3.57%
benchmarks/size=19531 depth=7 wide=5 mode=cached 577.7±87.04µs 704.1±195.59µs +21.88%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.9±0.14ms 3.9±0.60ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 450.6±70.86µs 444.8±71.78µs -1.29%
benchmarks/size=54241 depth=5 wide=15 mode=cached 654.0±35.29µs 653.2±53.39µs -0.12%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.4±0.29ms 7.3±0.11ms -1.35%

Copy link

github-actions bot commented Feb 6, 2024

Benchmark for 692af8c

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.3±0.36ms 30.6±1.10ms +0.99%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1576.6±12.98µs 1581.0±13.51µs +0.28%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 149.5±1.27µs 150.2±1.29µs +0.47%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.2±0.53ms 26.1±0.27ms -0.38%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.58ms 2.8±0.57ms +3.70%
benchmarks/size=19531 depth=7 wide=5 mode=cached 544.9±13.21µs 543.8±18.07µs -0.20%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.3±0.06ms 3.6±0.08ms +9.09%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 443.9±70.20µs 444.6±48.00µs +0.16%
benchmarks/size=54241 depth=5 wide=15 mode=cached 629.1±128.65µs 639.5±14.19µs +1.65%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.2±0.09ms 7.2±0.15ms 0.00%

Copy link

github-actions bot commented Feb 6, 2024

Benchmark for e9c9ebc

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.6±0.48ms 30.9±0.64ms +0.98%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1598.5±20.16µs 1591.1±54.52µs -0.46%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 150.3±1.15µs 150.2±1.85µs -0.07%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.8±0.13ms 26.2±0.44ms +1.55%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.60ms 2.7±0.62ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 506.6±14.77µs 521.2±16.64µs +2.88%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.3±0.18ms 3.3±0.12ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 443.8±73.64µs 441.5±28.95µs -0.52%
benchmarks/size=54241 depth=5 wide=15 mode=cached 618.2±17.62µs 625.0±53.65µs +1.10%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.2±0.39ms 7.2±0.06ms 0.00%

Copy link

github-actions bot commented Feb 6, 2024

Benchmark for 1c53796

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.5±0.53ms 30.9±0.93ms +1.31%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1578.4±16.33µs 1587.2±12.27µs +0.56%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 149.6±1.11µs 150.6±2.23µs +0.67%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.1±1.04ms 25.6±0.27ms -1.92%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.58ms 2.8±0.54ms +3.70%
benchmarks/size=19531 depth=7 wide=5 mode=cached 602.4±103.06µs 523.3±24.82µs -13.13%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.7±0.43ms 3.4±0.16ms -8.11%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 436.4±68.78µs 438.6±14.16µs +0.50%
benchmarks/size=54241 depth=5 wide=15 mode=cached 673.5±68.99µs 642.0±16.41µs -4.68%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.5±0.10ms 7.3±0.22ms -2.67%

@marc2332 marc2332 removed the blocked label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Benchmark for 3a5663b

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 28.5±0.51ms 30.4±0.53ms +6.67%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1574.2±13.35µs 1666.3±17.03µs +5.85%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 149.2±1.27µs 159.5±1.57µs +6.90%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.0±0.66ms 26.0±0.30ms -3.70%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.57ms 2.7±0.61ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 517.4±23.23µs 522.3±14.65µs +0.95%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.3±0.19ms 3.3±0.06ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 449.5±71.02µs 439.3±5.97µs -2.27%
benchmarks/size=54241 depth=5 wide=15 mode=cached 620.9±14.19µs 640.4±84.25µs +3.14%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.2±0.08ms 7.3±0.12ms +1.39%

Copy link

github-actions bot commented Feb 6, 2024

Benchmark for 426e3ad

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.7±1.53ms 30.9±0.78ms +0.65%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1583.1±7.14µs 1588.1±32.65µs +0.32%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 148.8±2.25µs 149.0±2.26µs +0.13%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.1±0.10ms 25.2±0.10ms -3.45%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.60ms 2.7±0.55ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 490.5±6.11µs 736.5±283.06µs +50.15%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.2±0.09ms 3.1±0.02ms -3.13%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 436.3±72.02µs 438.1±47.88µs +0.41%
benchmarks/size=54241 depth=5 wide=15 mode=cached 633.5±53.74µs 627.7±42.18µs -0.92%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.2±0.10ms 7.2±0.13ms 0.00%

Copy link

github-actions bot commented Feb 6, 2024

Benchmark for 9d86e85

Click to view benchmark
Test Base PR %
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 30.6±0.22ms 30.3±0.74ms -0.98%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1588.2±13.09µs 2.0±0.06ms +25.93%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 151.2±1.35µs 150.6±4.28µs -0.40%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.5±0.21ms 25.4±0.20ms -0.39%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 2.7±0.55ms 2.7±0.56ms 0.00%
benchmarks/size=19531 depth=7 wide=5 mode=cached 497.7±22.47µs 492.7±16.48µs -1.00%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 3.2±0.06ms 3.2±0.07ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 448.8±67.85µs 442.6±54.18µs -1.38%
benchmarks/size=54241 depth=5 wide=15 mode=cached 650.2±12.46µs 627.1±20.23µs -3.55%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.3±0.23ms 7.2±0.08ms -1.37%

@marc2332 marc2332 merged commit a7a182c into main Feb 6, 2024
5 checks passed
@marc2332 marc2332 deleted the feat/updated-dioxus branch February 6, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dioxus🧬 Related to dioxus APIs enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracking: Dioxus 0.5 support
1 participant