-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed BITPOS command #716
Fixed BITPOS command #716
Conversation
742731e
to
984c773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jainbhavya53 please add some unit tests.
Added these, https://github.com/DiceDB/dice/pull/716/files#diff-1342a5b50a066be247a6fcd8b958277226dc46bb72add2e7ea09096d74453263 |
@lucifercr07 Can you please review the changes ? |
@lucifercr07 Gentle Reminder, please review the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing.
Closes #669 #670