Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BITPOS command #716

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Fixed BITPOS command #716

merged 5 commits into from
Sep 27, 2024

Conversation

jainbhavya53
Copy link
Contributor

@jainbhavya53 jainbhavya53 commented Sep 25, 2024

Closes #669 #670

@jainbhavya53 jainbhavya53 marked this pull request as ready for review September 25, 2024 07:04
Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jainbhavya53 please add some unit tests.

@jainbhavya53
Copy link
Contributor Author

@jainbhavya53
Copy link
Contributor Author

@lucifercr07 Can you please review the changes ?

@jainbhavya53
Copy link
Contributor Author

@lucifercr07 Gentle Reminder, please review the changes

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing.

@lucifercr07 lucifercr07 merged commit c157d11 into DiceDB:master Sep 27, 2024
2 checks passed
@jainbhavya53 jainbhavya53 deleted the bug/669 branch September 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent BITPOS: BITPOS bit=0 works with intervals
2 participants