Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent BITPOS: BITPOS bit=1 works with intervals #670

Closed
lucifercr07 opened this issue Sep 20, 2024 · 9 comments
Closed

Inconsistent BITPOS: BITPOS bit=1 works with intervals #670

lucifercr07 opened this issue Sep 20, 2024 · 9 comments
Assignees

Comments

@lucifercr07
Copy link
Contributor

lucifercr07 commented Sep 20, 2024

Steps to reproduce

Run the commands mentioned in the test on Line 380 in the file https://github.com/AshwinKul28/dice-tests/blob/main/tcltests/unit/bitpos.tcl#L380.

Expected output

The expected output when the above set of commands when run on Redis

Expected [r bitpos str 1 8 -1 bit]

Observed output

The observed output when the above set of commands when run on DiceDB

8 (context: type eval line 10 cmd {assert {[r bitpos str 1 8 -1 bit]

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done:

  1. Changes in the dice repository code to meet the expected behavior.
  2. Successful run of the tcl test behavior.

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@Nijin-P-S
Copy link
Contributor

Hi @lucifercr07 , can you assign this task to me?

@karandixit10
Copy link
Contributor

Hi @lucifercr07, can I take this up?

@jainbhavya53
Copy link
Contributor

Hi @lucifercr07
Can I take this up ? Would love to work on it.
Thanks

@AshwinKul28
Copy link
Contributor

@Nijin-P-S Go for it. Thanks

@karandixit10 @jainbhavya53 Please check for other opened issues. Thanks for your interest. Means a lot!

@lucifercr07
Copy link
Contributor Author

@karandixit10 assigned, thanks for picking this up.

@karandixit10
Copy link
Contributor

Hi @lucifercr07 This issue has the same scenario as #669. Shall I work on this or is it being worked on by someone else?

@jainbhavya53
Copy link
Contributor

PR: #716

@jainbhavya53
Copy link
Contributor

@lucifercr07 Can you please assign this issue to me and close it ?
Its fixed by #716

@lucifercr07
Copy link
Contributor Author

Merged as part of #716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants