SET with EX with big integer reports an error #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patch looks good. @nithinkjoy-tech thanks a ton. merging it. |
|
Thanks @nithinkjoy-tech for the fix, this will work for most of the cases, but the precise value as follows. The max value redis supports is based on the maximum signed 64-bit integer (int64) which is 9223372036854775807. Since redis accepts it in milliseconds the max value would be 9223372036854775 milliseconds, which corresponds to maximum duration that Redis can represent before exceeding the range of a signed 64-bit integer. I will fix this in the next PR. cc - @arpitbbhayani . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511
Passes TCL Test
Passes existing dice tests
Working Example. (Changed port number to 6379 locally for running server)
