Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent SET: SET with EX with big integer should report an error #511

Closed
AshwinKul28 opened this issue Sep 8, 2024 · 2 comments · Fixed by #563
Closed

Inconsistent SET: SET with EX with big integer should report an error #511

AshwinKul28 opened this issue Sep 8, 2024 · 2 comments · Fixed by #563
Assignees
Labels

Comments

@AshwinKul28
Copy link
Contributor

Steps to reproduce

Run the commands mentioned in the test on Line 88 in the file https://github.com/AshwinKul28/dice-tests/tree/main/tcltests/unit/expire.tcl#L88.

Expected output

The expected output when the above set of commands when run on Redis

ERR invalid expire time in 'set' command

Observed output

The observed output when the above set of commands when run on DiceDB

OK

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. Successful run of the tcl test behavior

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@nithinkjoy-tech
Copy link
Contributor

Hi @arpitbbhayani I would like to work on this issue.

@lucifercr07
Copy link
Contributor

@nithinkjoy-tech assigned, thanks for picking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants