Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#145 : Added support for COMMAND COUNT command #153

Merged
merged 7 commits into from
Jul 28, 2024

Conversation

VipinRaiP
Copy link
Contributor

@VipinRaiP VipinRaiP commented Jul 14, 2024

Summary

Added support for count command. Please review.
COMMAND COUNT is used to get total number of commands in dicedb.
redis documentation : https://redis.io/docs/latest/commands/command-count
This is my first PR and just getting started with the project. I have referred @yashs360's PR #150 for making the code changes. Thank you @yashs360

Changes

Benchmark results

image

Issue : #145

@VipinRaiP VipinRaiP force-pushed the issue-145 branch 2 times, most recently from 18c7c5f to 4220fd4 Compare July 14, 2024 06:54
@arpitbbhayani
Copy link
Contributor

@VipinRaiP in case you missed it. Let me know by where are you planning to wrap it up?

@VipinRaiP
Copy link
Contributor Author

@VipinRaiP in case you missed it. Let me know by where are you planning to wrap it up?

Hi @arpitbbhayani
Sorry for the delay, i will fix these issues and push updated code over this weekend .
Please excuse

@VipinRaiP
Copy link
Contributor Author

@VipinRaiP in case you missed it. Let me know by where are you planning to wrap it up?

I have fixed the issues and pushed a new commit, thanks

@JyotinderSingh
Copy link
Collaborator

Left some minor comments.

@gsarmaonline
Copy link
Contributor

This PR #170 will have some conflicts with the current PR.

@VipinRaiP
Copy link
Contributor Author

This PR #170 will have some conflicts with the current PR.

Should this PR wait until #170 is merged and make changes as per new code?

@JyotinderSingh
Copy link
Collaborator

This PR #170 will have some conflicts with the current PR.

Should this PR wait until #170 is merged and make changes as per new code?

Hi @VipinRaiP, thanks for all the changes so far. #170 has been merged now. Please rebase your changes on top of the latest master and fix any conflicts that may be there. Once you have addressed the reviews, please resolve those comments and I will review this again.

@VipinRaiP
Copy link
Contributor Author

This PR #170 will have some conflicts with the current PR.

Should this PR wait until #170 is merged and make changes as per new code?

Hi @VipinRaiP, thanks for all the changes so far. #170 has been merged now. Please rebase your changes on top of the latest master and fix any conflicts that may be there. Once you have addressed the reviews, please resolve those comments and I will review this again.

Rebased and pushed a new commit, please review

JyotinderSingh
JyotinderSingh previously approved these changes Jul 28, 2024
@JyotinderSingh
Copy link
Collaborator

Approved, will merge soon.
Could you please update the benchmark screenshot (since we have made some changes now) @VipinRaiP

@JyotinderSingh
Copy link
Collaborator

@VipinRaiP Looks like a unit test is failing with these changes, could you please look into it?

@JyotinderSingh JyotinderSingh dismissed their stale review July 28, 2024 14:10

unit test failures

@VipinRaiP VipinRaiP requested a review from JyotinderSingh July 28, 2024 15:14
@JyotinderSingh JyotinderSingh merged commit b400d34 into DiceDB:master Jul 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants