-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#145 : Added support for COMMAND COUNT command #153
Conversation
18c7c5f
to
4220fd4
Compare
@VipinRaiP in case you missed it. Let me know by where are you planning to wrap it up? |
Hi @arpitbbhayani |
I have fixed the issues and pushed a new commit, thanks |
Left some minor comments. |
This PR #170 will have some conflicts with the current PR. |
Hi @VipinRaiP, thanks for all the changes so far. #170 has been merged now. Please rebase your changes on top of the latest master and fix any conflicts that may be there. Once you have addressed the reviews, please resolve those comments and I will review this again. |
…ts on variable names and assertions
Rebased and pushed a new commit, please review |
Approved, will merge soon. |
@VipinRaiP Looks like a unit test is failing with these changes, could you please look into it? |
Summary
Added support for count command. Please review.
COMMAND COUNT is used to get total number of commands in dicedb.
redis documentation : https://redis.io/docs/latest/commands/command-count
This is my first PR and just getting started with the project. I have referred @yashs360's PR #150 for making the code changes. Thank you @yashs360
Changes
Benchmark results
Issue : #145