Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COMMAND COUNT command #145

Closed
arpitbbhayani opened this issue Jul 12, 2024 · 3 comments
Closed

Add support for COMMAND COUNT command #145

arpitbbhayani opened this issue Jul 12, 2024 · 3 comments

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the COMMAND COUNT command in DiceDB similar to the COMMAND COUNT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@dhruvdabhi101
Copy link

I would like to work on it. Can you please assign this issue to me ?

@JyotinderSingh
Copy link
Collaborator

JyotinderSingh commented Jul 22, 2024

I would like to work on it. Can you please assign this issue to me ?

Looks like #153 is already under review for this. Please take a look at other open issues that are not yet being worked on.

@AshwinKul28
Copy link
Contributor

@JyotinderSingh If already merged, good to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants