Allow creating all devices when device instantiation(s) raise an exception #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes DiamondLightSource#56 - e.g. a = dict - e.g. from ophyd.utils import DisconnectedError
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 84.93% 85.16% +0.22%
==========================================
Files 52 52
Lines 1660 1685 +25
==========================================
+ Hits 1410 1435 +25
Misses 250 250
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@DiamondJoseph what is the state of this? Anything we can help with to get it merged? |
|
Going to close and resurrect when required |
|
From discussion: Should make this behaviour configurable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58 but as an optional behaviour. Changes the behaviour of make_all_devices to not fail at the first exception, but to collect all exceptions from devices that failed to instantiate and raise an ExceptionBundle with them all (unless there is only 1 device, with no dependencies that fails to instantiate, then the raise is just delayed until all other devices are tried)
Requires #61 (to allow importing an Exception that is thrown by the device instantiation)