Allow aliased or extended builtin imports in device modules #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DiamondJoseph
commented
May 17, 2023
DiamondJoseph
commented
- Fixes make_all_devices crashes if it finds dict in a module #56
- e.g. a = dict
- e.g. from ophyd.utils import DisconnectedError
tpoliaw
approved these changes
May 17, 2023
DominicOram
requested changes
May 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 85.81% 85.84% +0.02%
==========================================
Files 52 52
Lines 1678 1681 +3
==========================================
+ Hits 1440 1443 +3
Misses 238 238
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.