This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
darwin.js - crossover strategy #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation.
DeviaVir
approved these changes
Jan 6, 2018
DeviaVir
added a commit
that referenced
this pull request
Jan 7, 2018
* bring the recent commits to master down into unstable (#1048) * update products.json file to newest trading pairs at binance (#1028) * Binance changed API 24 hours to 1 hour (#1027) * Update README * Update README again * add generation data to gitignore (#1012) * binance changed their API strategy from 24 hour windows to 1 hour. * rename periodLength to period_length (#1035) * Change markup_pct to new markdown and markup, set commonArgs so it is included in all strategies, fix return. (#1047) The only other occurrence is in the readme file noting the legacy aspect. * Update darwin.js * Added support for dema-strategy to darwin.js (#1046) * fix bad escaping on output to console (#1045) * Update periodLength to underscore syntax for darwin * Missing | lead to bitwise operation being performed rather than an OR logical comparison. (#1053) * Console Output adjustment (#1055) * resolution to .csv & .json output (#1058) * resolution to .csv & .json output trogdor123 got me looking at the right section where the params were being input in json. made some minor tweaks to the code and now both are outputting correctly. * Update darwin.js ...changes - formatting. * darwin.js - crossover strategy (#1060) noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation. * Docker (#1061) * docker fix * Resolve docker build problems * noop strategy: readme/links/list (#1062) * Travis. Docker. (#1063) * Updated minimum required node version (#1066) It appears Zenbot wont work on anything before 8.3.0. Updating the minimum required version, for clarity. * Merge DemaStrats (#1067) fixes #1064 * v4.1.0: prepare release (#1068) * v4.1.0: prepare release * update package-lock.json
|
@shr00mie @DeviaVir I left these out on purpose because the crossover strategy doesn't currently use these for decision making: Only ema1 and vwap are currently used. So having those in the darwin parameters may only add more required tests before you start seeing improvements. The only affect they might have, is that they require more periods before the strategy kicks in, since the signal checks don't happen until all parameters are populated: Realistically the strategy needs to be enhanced to either make these extra parameters an optional alternative to the ema comparison, or removing them completely. |
This was referenced Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation.