Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

darwin.js - crossover strategy #1060

Merged
merged 1 commit into from
Jan 6, 2018
Merged

darwin.js - crossover strategy #1060

merged 1 commit into from
Jan 6, 2018

Conversation

shr00mie
Copy link
Contributor

@shr00mie shr00mie commented Jan 6, 2018

noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation.

noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation.
@DeviaVir DeviaVir merged commit 3d56a7c into DeviaVir:unstable Jan 6, 2018
DeviaVir added a commit that referenced this pull request Jan 7, 2018
* bring the recent commits to master down into unstable (#1048)

* update products.json file to newest trading pairs at binance (#1028)

* Binance changed API 24 hours to 1 hour (#1027)

* Update README

* Update README again

* add generation data to gitignore (#1012)

* binance changed their API strategy from 24 hour windows to 1 hour.

* rename periodLength to period_length (#1035)

* Change markup_pct to new markdown and markup, set commonArgs so it is included in all strategies, fix return. (#1047)

The only other occurrence is in the readme file noting the legacy aspect.

* Update darwin.js

* Added support for dema-strategy to darwin.js (#1046)

* fix bad escaping on output to console (#1045)

* Update periodLength to underscore syntax for darwin

* Missing | lead to bitwise operation being performed rather than an OR logical comparison. (#1053)

* Console Output adjustment (#1055)

* resolution to .csv & .json output (#1058)

* resolution to .csv & .json output

trogdor123 got me looking at the right section where the params were being input in json. made some minor tweaks to the code and now both are outputting correctly.

* Update darwin.js

...changes - formatting.

* darwin.js - crossover strategy (#1060)

noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation.

* Docker (#1061)

* docker fix

* Resolve docker build problems

* noop strategy: readme/links/list (#1062)

* Travis. Docker. (#1063)

* Updated minimum required node version (#1066)

It appears Zenbot wont work on anything before 8.3.0.  Updating the minimum required version, for clarity.

* Merge DemaStrats (#1067)

fixes #1064

* v4.1.0: prepare release (#1068)

* v4.1.0: prepare release

* update package-lock.json
@shr00mie shr00mie deleted the patch-2 branch January 7, 2018 05:44
@tiagosiebler
Copy link
Contributor

@shr00mie @DeviaVir I left these out on purpose because the crossover strategy doesn't currently use these for decision making:
https://github.com/DeviaVir/zenbot/blob/unstable/extensions/strategies/crossover_vwap/strategy.js#L70

Only ema1 and vwap are currently used. So having those in the darwin parameters may only add more required tests before you start seeing improvements. The only affect they might have, is that they require more periods before the strategy kicks in, since the signal checks don't happen until all parameters are populated:
https://github.com/DeviaVir/zenbot/blob/unstable/extensions/strategies/crossover_vwap/strategy.js#L68

Realistically the strategy needs to be enhanced to either make these extra parameters an optional alternative to the ema comparison, or removing them completely.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants