Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Binance changed API 24 hours to 1 hour #1027

Merged
merged 6 commits into from
Jan 2, 2018
Merged

Conversation

mkuendig
Copy link
Contributor

@mkuendig mkuendig commented Jan 1, 2018

No description provided.

Copy link
Owner

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeviaVir DeviaVir merged commit 860dfc5 into DeviaVir:master Jan 2, 2018
DeviaVir pushed a commit that referenced this pull request Jan 5, 2018
* update products.json file to newest trading pairs at binance (#1028)

* Binance changed API 24 hours to 1 hour (#1027)

* Update README

* Update README again

* add generation data to gitignore (#1012)

* binance changed their API strategy from 24 hour windows to 1 hour.

* rename periodLength to period_length (#1035)
DeviaVir added a commit that referenced this pull request Jan 7, 2018
* bring the recent commits to master down into unstable (#1048)

* update products.json file to newest trading pairs at binance (#1028)

* Binance changed API 24 hours to 1 hour (#1027)

* Update README

* Update README again

* add generation data to gitignore (#1012)

* binance changed their API strategy from 24 hour windows to 1 hour.

* rename periodLength to period_length (#1035)

* Change markup_pct to new markdown and markup, set commonArgs so it is included in all strategies, fix return. (#1047)

The only other occurrence is in the readme file noting the legacy aspect.

* Update darwin.js

* Added support for dema-strategy to darwin.js (#1046)

* fix bad escaping on output to console (#1045)

* Update periodLength to underscore syntax for darwin

* Missing | lead to bitwise operation being performed rather than an OR logical comparison. (#1053)

* Console Output adjustment (#1055)

* resolution to .csv & .json output (#1058)

* resolution to .csv & .json output

trogdor123 got me looking at the right section where the params were being input in json. made some minor tweaks to the code and now both are outputting correctly.

* Update darwin.js

...changes - formatting.

* darwin.js - crossover strategy (#1060)

noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation.

* Docker (#1061)

* docker fix

* Resolve docker build problems

* noop strategy: readme/links/list (#1062)

* Travis. Docker. (#1063)

* Updated minimum required node version (#1066)

It appears Zenbot wont work on anything before 8.3.0.  Updating the minimum required version, for clarity.

* Merge DemaStrats (#1067)

fixes #1064

* v4.1.0: prepare release (#1068)

* v4.1.0: prepare release

* update package-lock.json
@YuriyTigiev
Copy link

Hello,

I have the same error, but zenbot works properly with --paper, and doesn't work in a trade mode.
What is solution? I have ubuntu 18.04. I updated the time zone and I synchronized time.
I'm using the latest version of zenbot.

------------------------------------------ INITIALIZE OUTPUT ------------------------------------------
---------------------------------------- STARTING LIVE TRADING ----------------------------------------
Press l to list available commands.
Web GUI running on http://192.168.1.10:20022/
An error occurred { Error: binance {"code":-1021,"msg":"Timestamp for this request was 1000ms ahead of the server's time."}
at binance.handleErrors (/home/ytigiev/zenbot/node_modules/ccxt/js/binance.js:981:31)
at response.text.then (/home/ytigiev/zenbot/node_modules/ccxt/js/base/Exchange.js:600:18)
at
at process._tickCallback (internal/process/next_tick.js:188:7) constructor: [Function: InvalidNonce] }

Binance API is down! unable to call getBalance, retrying in 20s
[ { currency: 'BTC', asset: 'ETC' } ]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants