Move LICENSE back to root and fix builds #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaiwat10
reviewed
Nov 29, 2021
| { src: 'LICENSE', dest: 'dist' }, | ||
| { src: 'README.md', dest: 'dist' }, | ||
| { src: '../../LICENSE', dest: 'dist' }, | ||
| { src: '../../README.md', dest: 'dist' }, |
There was a problem hiding this comment.
Don't we want the README to be separate for both the hooks and the components package? 🤔
There was a problem hiding this comment.
Maybe someday? but we only have one README file today :P So might as well use that shared one everywhere for now.
And this will probably all change with our new build/publishing system plans, this was mainly to keep the status quo from before the monorepo work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #27, we should have the LICENSE file in the root of the repo (so github picks it up), and we should make sure it gets pulled into the build output appropriately
to: @Dhaiwat10 @crondinini