Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monorepo setup discussion #27

Closed
Dhaiwat10 opened this issue Nov 29, 2021 · 5 comments
Closed

Monorepo setup discussion #27

Dhaiwat10 opened this issue Nov 29, 2021 · 5 comments
Labels
discussion

Comments

@Dhaiwat10
Copy link
Member

Please use this thread as the place to open a discussion about the monorepo setup (#26) or to suggest any improvements!
@Dhaiwat10 Dhaiwat10 mentioned this issue Nov 29, 2021
Merged
@etr2460
Copy link
Contributor

etr2460 commented Nov 29, 2021

oops, looks like i was a minute or two late with PR comments. I might make a PR to add in the changes i listed here: #26 (review)

@Dhaiwat10
Copy link
Member Author

@etr2460 thank you! Please do that and I'll merge it in asap

@etr2460
Copy link
Contributor

etr2460 commented Nov 29, 2021

opened #28!

@Dhaiwat10
Copy link
Member Author

#28 merged

@etr2460 etr2460 mentioned this issue Nov 29, 2021
Merged
@crondinini
Copy link
Contributor

Is there any further discussion needed? Seems like the improvements are in this other issue:
#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@etr2460 @crondinini @Dhaiwat10