Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monorepo package.jsons #28

Merged

Conversation

etr2460
Copy link
Contributor

@etr2460 etr2460 commented Nov 29, 2021

Address comments I made in #26 (review) shortly after the PR was merged 😛 🐌

to: @Dhaiwat10 @crondinini

@etr2460 etr2460 mentioned this pull request Nov 29, 2021
@Dhaiwat10
Copy link
Member

Great suggestions. Why is the build failing tho? 🤔 I'm gonna try checking out this PR and running stuff locally.

@etr2460
Copy link
Contributor Author

etr2460 commented Nov 29, 2021

oh lol:

error Couldn't find package "@web3-ui/hooks@1.0.0" required by "@web3-ui/components@0.0.1" on the "npm" registry.

@etr2460 etr2460 force-pushed the erik-ritter--iterate-on-monorepo branch from 4621910 to f88e7ea Compare November 29, 2021 04:48
@etr2460
Copy link
Contributor Author

etr2460 commented Nov 29, 2021

@Dhaiwat10 CI is now green

@Dhaiwat10 Dhaiwat10 merged commit 9fd8056 into Developer-DAO:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants