Replace stack code with IMaterial #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the AccelStruct would take material information from Lua. Now, it takes information directly from source. Theoretically this should make it faster (I feel it's faster), but I've done no benchmarks yet.
|
Either disable those warnings or use a function that checks if a key exists first |
Derpius
requested changes
Sep 17, 2022
Derpius
changed the title
Derpius
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
PR Type (tick all that are applicable)
Tested Targets (only applicable for changes to the binary module, delete otherwise)
Checklist
Description
Before this commit, the AccelStruct would take material information from Lua. Now, it takes information directly from source.
Theoretically this should make it faster (I feel it's faster), but I've done no benchmarks yet.
There are definitely stylistic issues with the PR and some design choices that need to be reconsidered, so please review carefully.
Also:
This can be disabled, so let me know if it should be.