Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Replace stack-based material reading with IMaterial #70

Closed
Derpius opened this issue Sep 16, 2022 · 1 comment · Fixed by #72
Closed

[feature] Replace stack-based material reading with IMaterial #70

Derpius opened this issue Sep 16, 2022 · 1 comment · Fixed by #72
Labels
binary module Issues relating to the binary module enhancement New feature or request good first issue Good for newcomers
Milestone
v0.12.0

Comments

@Derpius
Copy link
Owner

Derpius commented Sep 16, 2022

Is your feature request related to a problem? Please describe.
The current method for reading IMaterial properties off the stack is cumbersome and inefficient.

Describe the solution you'd like
Implement the real IMaterial class in order to interface with the userdata directly.

Additional context
https://github.com/ValveSoftware/source-sdk-2013/blob/master/sp/src/public/materialsystem/imaterial.h#L446-L604
@Derpius Derpius added enhancement New feature or request binary module Issues relating to the binary module labels Sep 16, 2022
@Derpius Derpius added this to the v0.12.0 milestone Sep 16, 2022
@Derpius Derpius added the good first issue Good for newcomers label Sep 16, 2022
@yogwoggf
Copy link
Contributor

Got the implementation in C++ fully working. Going to make everything use it 😘😏

@yogwoggf yogwoggf mentioned this issue Sep 17, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binary module Issues relating to the binary module enhancement New feature or request good first issue Good for newcomers
Projects
VisTrace
Status: Done
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Replace stack code with IMaterial yogwoggf/VisTrace
2 participants
@Derpius @yogwoggf