Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump numpy #616

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Bump numpy #616

merged 2 commits into from
Oct 25, 2023

Conversation

savente93
Copy link
Contributor

@savente93 savente93 commented Oct 25, 2023

Issue addressed

Fixes #614

Explanation

Since numpy 1.22 is EOL now, it would be good to update so that people don't use unsupported versions. Since 1.22's EOL is in 2 months (source: https://endoflife.date/numpy) I've decided to just bump it to 1.23 directly. this gives us 8 months before we need to update further so that seems like a good idea. Currently the numpy version esolves to 1.24 (in my environment) so using 1.23 should be fine for the time being.

I've also added a dependabot alerting so that we are notified of these things a bit more frequently. Sadly it doesn't support conda dependencies, but since our conda dependencies mirror that of pip (it's built from pyproject.toml) having alerts for pip EOLs is a close enough analog imo, we can always investigate further from there if necessary.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@savente93 savente93 marked this pull request as ready for review October 25, 2023 08:39
@savente93 savente93 requested a review from Jaapel October 25, 2023 08:46
@savente93 savente93 merged commit 461de62 into main Oct 25, 2023
9 checks passed
@savente93 savente93 deleted the bump-numpy branch October 25, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider bumping numpy version since numpy 1.21 is EOL
2 participants