Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider bumping numpy version since numpy 1.21 is EOL #614

Closed
veenstrajelmer opened this issue Oct 25, 2023 · 1 comment · Fixed by #616
Closed

Consider bumping numpy version since numpy 1.21 is EOL #614

veenstrajelmer opened this issue Oct 25, 2023 · 1 comment · Fixed by #616
Labels
Enhancement New feature or request

Comments

@veenstrajelmer
Copy link
Collaborator

Kind of request

Changing existing functionality

Enhancement Description

I noticed numpy>=1.20 in pyproject.toml. Since numpy 1.21 is EOL according to this and this, it might be good to update this to numpy>=1.22. Optional of course, but might be someting to consider.

Use case

No response

Additional Context

No response
@veenstrajelmer veenstrajelmer added Enhancement New feature or request Needs refinement issue still needs refinement labels Oct 25, 2023
@savente93 savente93 mentioned this issue Oct 25, 2023
Merged
5 tasks
@savente93
Copy link
Contributor

Thanks for reporting this! I've opened a pull request for it, so hopefully that will get merged soon enough. I've actually bumped it straight to 1.23 since the EOL of 1.22 is in two months.

@savente93 savente93 removed the Needs refinement issue still needs refinement label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump numpy Deltares/hydromt
2 participants
@savente93 @veenstrajelmer