-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small Model updates #534
Small Model updates #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most changes look good. However for the renaming we need to have a bit more input from users. What are clear naming conventions and do we apply it to all components incl geoms and maps that don't have an initial setup method? I suggest to revert the renaming and keep that for a separate PR after organizing a small user panel feedback session.
This reverts commit bae546f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ready to merge! The renaming has been taken out and parked for discussion in #475
Issue addressed
Fixes #524
Fixes #498
Explanation
See related issues
Checklist
main
Additional notes
For #475 I only renamed the setup_ methods and not the workflow methods. Not sure if I should rename them as well?