Small Model updates #534
Merged
Small Model updates #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirkEilander
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Most changes look good. However for the renaming we need to have a bit more input from users. What are clear naming conventions and do we apply it to all components incl geoms and maps that don't have an initial setup method? I suggest to revert the renaming and keep that for a separate PR after organizing a small user panel feedback session.
This reverts commit bae546f.
savente93
added
Blocked
DirkEilander
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
This PR is ready to merge! The renaming has been taken out and parked for discussion in #475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #524
Fixes #498
Explanation
See related issues
Checklist
mainAdditional notes
For #475 I only renamed the setup_ methods and not the workflow methods. Not sure if I should rename them as well?